Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move test-child-process-fork-getconnections to parallel #30749

Merged
merged 2 commits into from
Dec 3, 2019
Merged

test: move test-child-process-fork-getconnections to parallel #30749

merged 2 commits into from
Dec 3, 2019

Commits on Dec 3, 2019

  1. test: change common.PORT to arbitrary port 

    Change common.PORT to arbitrary port in
test-child-process-fork-getconnections to prepare for moving that test
from sequential to parallel.

PR-URL: nodejs#30749
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @Trott
    Trott committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    4f5685d View commit details
    Browse the repository at this point in the history

  2. test: move test-child-process-fork-getconnections to parallel 

    Now that the test uses an open port assigned by the operating system
rather than a hardcoded common.PORT, it can be moved to parallel.

PR-URL: nodejs#30749
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @Trott
    Trott committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    890d643 View commit details
    Browse the repository at this point in the history