Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: prevent previews during pasting #31315

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Jan 11, 2020

This is based on #31288 and therefore the two first commits should be ignored. I'll rebase as soon as the other PR lands.
Update: done.

This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR BridgeAR added the blocked PRs that are blocked by other issues or PRs. label Jan 11, 2020
@nodejs-github-bot nodejs-github-bot added readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem. labels Jan 11, 2020
@BridgeAR BridgeAR force-pushed the 2020-01-11-repl-prevent-previews-during-pasting branch from 7dabd1e to fe738a3 Compare January 11, 2020 22:19
@BridgeAR BridgeAR removed the blocked PRs that are blocked by other issues or PRs. label Jan 11, 2020
@BridgeAR BridgeAR force-pushed the 2020-01-11-repl-prevent-previews-during-pasting branch from fe738a3 to eea1c73 Compare January 11, 2020 22:24
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2020
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.
@BridgeAR BridgeAR force-pushed the 2020-01-11-repl-prevent-previews-during-pasting branch from eea1c73 to 5f1cee3 Compare January 12, 2020 22:30
@BridgeAR
Copy link
Member Author

Rebased due to conflicts.

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member Author

@nodejs/repl @nodejs/readline PTAL

BridgeAR added a commit that referenced this pull request Jan 13, 2020
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

PR-URL: #31315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@BridgeAR
Copy link
Member Author

Landed in c3b702f 🎉

@BridgeAR BridgeAR closed this Jan 13, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

PR-URL: #31315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@codebytere codebytere mentioned this pull request Jan 16, 2020
@BridgeAR BridgeAR deleted the 2020-01-11-repl-prevent-previews-during-pasting branch January 20, 2020 12:09
@codebytere
Copy link
Member

@BridgeAR sorry for the many pings - this is in the group needing manual backport to 12 if it should indeed go there.

targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

PR-URL: nodejs#31315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
This makes sure no previews are triggered while pasting code. The
very last character is allowed to trigger the preview. The output
should be completely identical to the user.

PR-URL: #31315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants