Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.7.0 proposal #31382

Merged
merged 110 commits into from
Jan 21, 2020
Merged

v13.7.0 proposal #31382

merged 110 commits into from
Jan 21, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 16, 2020

2020-01-21, Version 13.7.0 (Current), @codebytere

Notable Changes

  • deps:
    • upgrade to libuv 1.34.1 (cjihrig) #31332
    • upgrade npm to 6.13.6 (Ruy Adorno) #31304
  • doc:
    • add GeoffreyBooth to collaborators (Geoffrey Booth) #31306
  • module
    • add API for interacting with source maps (bcoe) #31132
    • loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
    • logical conditional exports ordering (Guy Bedford) #31008
    • unflag conditional exports (Guy Bedford) #31001
  • process:
    • allow monitoring uncaughtException (Gerhard Stoebich) #31257

Commits

  • [9d26358cfe] - async_hooks: remove internal only error checking (Anatoli Papirovski) #30967
  • [6e978f7d73] - benchmark: add default type in getstringwidth.js (Rich Trott) #31377
  • [317d2dba45] - benchmark: benchmarking impacts of async hooks on promises (legendecas) #31188
  • [55e2b4ee3b] - build: remove enable_vtune from vcbuild.bat (Richard Lau) #31338
  • [f11406de43] - build: add vs2019 to vcbuild.bat help (Richard Lau) #31338
  • [b2180d932a] - build: fix macos runner type in GitHub Action (扩散性百万甜面包) #31327
  • [a6e1e9c6c3] - build: fix step name in GitHub Actions workflow (Richard Lau) #31323
  • [0379c319fd] - build: add GitHub actions to run linters (Richard Lau) #31323
  • [a31eed0214] - build: silence OpenSSL Windows compiler warnings (Richard Lau) #31311
  • [6b118b44e8] - build: silence c-ares Windows compiler warnings (Richard Lau) #31311
  • [7a5d4fad84] - build: test Python 3 using GitHub Actions-based CI (cclauss) #29474
  • [964371824c] - build: avoid using CMP for BZ2File (SpaceRacet5w2A6l0I) #31198
  • [22859367ca] - child_process: remove unnecessary use of inner state (Chetan Karande) #29358
  • [6d6a3e4551] - deps: V8: cherry-pick d89f4ef1cd62 (Milad Farazmand) #31354
  • [d62d06b3b7] - deps: V8: cherry-pick b9d33036e9a8 (Benjamin Coe) #31335
  • [51e4a5618b] - deps: upgrade to libuv 1.34.1 (cjihrig) #31332
  • [985f980053] - deps: upgrade npm to 6.13.6 (Ruy Adorno) #31304
  • [6f95f01f95] - deps: deactivate failing tests corresponding to experimental features (Ruben Bridgewater) #31289
  • [aed00d7d68] - doc: add missing code formatting in vm.md (cjihrig) #31350
  • [aedbfdb33a] - doc: standardize on "host name" in url.md (Rich Trott) #31326
  • [28245277d7] - doc: standardize on "host name" in tls.md (Rich Trott) #31326
  • [baeabff896] - doc: standardize on "host name" in os.md (Rich Trott) #31326
  • [94122f611a] - doc: standardize on "host name" in net.md (Rich Trott) #31326
  • [bac588e076] - doc: standardize on "host name" in https.md (Rich Trott) #31326
  • [600eb8b67c] - doc: standardize on "host name" in http2.md (Rich Trott) #31326
  • [47f71de786] - doc: standardize on "host name" in fs.md (Rich Trott) #31326
  • [ece70a8288] - doc: standardize on "host name" in errors.md (Rich Trott) #31326
  • [b8dee4540a] - doc: standardize on "host name" in dgram.md (Rich Trott) #31326
  • [8055f78995] - doc: standardize on "host name" in deprecations.md (Rich Trott) #31326
  • [6e9f0daad1] - doc: standardize on "host name" in async_hooks.md (Rich Trott) #31326
  • [e1fd6ae4fa] - doc: fix a code example in crypto.md (himself65) #31313
  • [bb9622ba5a] - doc: add an example for util.types.isExternal (Harshitha KP) #31173
  • [0608873052] - doc: fix example of parsing request.url (Egor Pavlov) #31302
  • [b9aca7849d] - doc: document readline key bindings (Harshitha KP) #31256
  • [6184f1ab70] - doc: improve doc v8.getHeapSpaceStatistics() 'GetHeapSpaceStatistics' (dev-313) #31274
  • [deff60024a] - doc: update README to make Node.js description clearer (carterbancroft) #31266
  • [8e14066578] - doc: fix a code example in zlib.md (Alexander Wang) #31264
  • [9c58aa4c75] - doc: add GeoffreyBooth to collaborators (Geoffrey Booth) #31306
  • [de6f2be0d0] - doc: update description of External (Anna Henningsen) #31255
  • [0e48d8d855] - doc: rename iterator to iterable in examples (Robert Nagy) #31252
  • [d51de787d9] - doc: fix stream async iterator sample (Robert Nagy) #31252
  • [3e7b3e3c18] - doc: correct filehandle.[read|write|append]File() (Bryan English) #31235
  • [220ea0c12e] - doc: prefer server vs srv and client vs clt (Andrew Hughes) #31224
  • [c1333ea113] - doc: explain native external types (Harshitha KP) #31214
  • [82b447c399] - doc,src: clarify that one napi_env is per-module (legendecas) #31102
  • [4981f9721a] - errors: remove dead code in ERR_INVALID_ARG_TYPE (Gerhard Stoebich) #31322
  • [b55fba2028] - fs: add missing HandleScope to FileHandle.close (Anna Henningsen) #31276
  • [57016b9e66] - fs: use async writeFile in FileHandle#appendFile (Bryan English) #31235
  • [52504fb91e] - http2: skip creating native ShutdownWrap (Anna Henningsen) #31283
  • [108046d910] - lib: replace BigInt64Array global by the primordials (Sebastien Ahkrin) #31193
  • [02714573ee] - lib: add Uint16Array primordials (Sebastien Ahkrin) #31210
  • [53e73fc60e] - lib: add RegExp primordials (Sebastien Ahkrin) #31208
  • [f7833ac934] - lib: replace Float32Array global by the primordials (Sebastien Ahkrin) #31195
  • [aafeab8cdb] - lib: replace BigUInt64Array global by the primordials (Sebastien Ahkrin) #31194
  • [ac904f9e65] - lib,tools,test: remove custom number-isnan rule (cjihrig) #31211
  • [ea27e16fc2] - (SEMVER-MINOR) module: unflag conditional exports (Guy Bedford) #31001
  • [4dced024fd] - (SEMVER-MINOR) module: add API for interacting with source maps (bcoe) #31132
  • [f62fb7603a] - module: logical conditional exports ordering (Guy Bedford) #31008
  • [94af94ae73] - module: loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
  • [c8aa08ed27] - n-api: return napi_invalid_arg on napi_create_bigint_words (legendecas) #31312
  • [0911813862] - (SEMVER-MINOR) n-api: add napi_get_all_property_names (himself65) #30006
  • [79eba6afa3] - (SEMVER-MINOR) process: allow monitoring uncaughtException (Gerhard Stoebich) #31257
  • [38811897c0] - readline: improve unicode support and tab completion (Ruben Bridgewater) #31288
  • [f0506c3dd2] - readline: move charLengthLeft() and charLengthAt() (Ruben Bridgewater) #31112
  • [7ba21d0e15] - readline: improve getStringWidth() (Ruben Bridgewater) #31112
  • [686a3bcf92] - readline,repl: support tabs properly (Ruben Bridgewater) #31112
  • [2e54a9922e] - readline,repl: improve history up/previous (Ruben Bridgewater) #31112
  • [cecd25693f] - readline,repl: skip history entries identical to the current line (Ruben Bridgewater) #31112
  • [b6f4e01a0e] - readline,repl: add substring based history search (Ruben Bridgewater) #31112
  • [85926d4038] - repl: do not preview while pasting code (Ruben Bridgewater) #31315
  • [c252356d38] - repl: fix preview cursor position (Ruben Bridgewater) #31293
  • [b9b044b98e] - repl: change preview default in case of custom eval functions (Ruben Bridgewater) #31259
  • [b92d65dbe7] - repl: activate previews for lines exceeding the terminal columns (Ruben Bridgewater) #31112
  • [d84c394541] - repl: improve preview length calculation (Ruben Bridgewater) #31112
  • [f8e805985e] - repl,readline: clean up code (Ruben Bridgewater) #31288
  • [83f7b5a8a9] - src: fix performance regression in node_file.cc (Ben Noordhuis) #31343
  • [6534c6c7bd] - src: use uv_guess_handle() to detect TTYs (cjihrig) #31333
  • [06fbc03cbd] - src: include uv.h in node_binding header (Shelley Vohr) #31265
  • [e3491d7dd6] - src: change GetStringWidth's expand_emoji_sequence option default (Ruben Bridgewater) #31112
  • [d2a10ad847] - src: improve GetColumnWidth performance (Ruben Bridgewater) #31112
  • [d0a96ab700] - src: fix -Wbraced-scalar-init warning (cjihrig) #31254
  • [60942cc2a7] - src: add build Github Action (gengjiawen) #31153
  • [4259afe583] - src: remove node::InitializeV8Platform() (Ben Noordhuis) #31245
  • [6050236c3d] - src: remove uses of node::InitializeV8Platform() (Ben Noordhuis) #31245
  • [1ad907039d] - src: clean up large_pages code (Denys Otrishko) #31196
  • [499c41d78a] - stream: fix async iterator destroyed error propagation (Robert Nagy) #31314
  • [d04118f125] - stream: simplify push (Robert Nagy) #31150
  • [ff60a0e2b1] - stream: clean up definition using defineProperties (antsmartian) #31236
  • [9c98d25506] - stream: replace Function.prototype with primordial (Sebastien Ahkrin) #31204
  • [256289fe83] - stream: sync stream unpipe resume (Robert Nagy) #31191
  • [424408005f] - test: stricten readline keypress failure test condition (Ruben Bridgewater) #31300
  • [1df7961b28] - test: allow disabling crypto tests (Shelley Vohr) #31268
  • [3c82d5bed2] - test: add repl tests to verify unicode support in previews (Ruben Bridgewater) #31112
  • [ca51ff8981] - test: fix recursive rm test to actually use tmpdir (Denys Otrishko) #31250
  • [0b88c3d8ed] - test: check that --insecure-http-parser works (Sam Roberts) #31253
  • [69c4f229cb] - test: remove unused symlink loop (cjihrig) #31267
  • [d76deca9cf] - test: prefer server over srv (Andrew Hughes) #31224
  • [f93095de6f] - test: fix unit test logging with python3 (Adam Majer) #31156
  • [5dd6fb1529] - tools: remove obsolete dependencies (Rich Trott) #31359
  • [29e0465104] - tools: update remark-preset-lint-node to 1.12.0 (Rich Trott) #31359
  • [49364b0835] - tools: update JSON header parsing for backticks (Rich Trott) #31294
  • [d48f59224b] - tools: ensure consistent perms of signed release files (Rod Vagg) #29350
  • [a5311bd757] - tools: add clang-tidy rule in src (gengjiawen) #26840
  • [63f4eaefee] - util: add todo comments for inspect to add unicode support (Ruben Bridgewater) #31112
  • [27564a4837] - (SEMVER-MINOR) vm: add code cache support for SourceTextModule (Gus Caplan) #31278
  • [bdaac04c10] - wasi: improve use of primordials (cjihrig) #31212
  • [66fe92353b] - win: change to use Python in install tool (gengjiawen) #31221

BridgeAR and others added 30 commits January 11, 2020 14:57
This comments out three tests that consistently fail on v13.x.
The test can be activated again in case the necessary code change
lands on v13.x for the tests to pass.

PR-URL: #31289
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #30986
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
PR-URL: #31008
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
pipe() ondata should not control flow state if cleaned up.

Fixes: #31190

PR-URL: #31191
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #31196
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #31194
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #31195
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #31212
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #31208
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit removes the custom number-isnan ESLint rule in
favor of the no-restricted-syntax rule. It also applies the
rule across the entire codebase, instead of just the test/
directory.

PR-URL: #31211
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #31102
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Some Python distributions do not support
context manager protocol (CMP) for BZ2File.

PR-URL: #31198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
PR-URL: #31204
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #31188
Refs: nodejs/diagnostics#124
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #31221
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
A logfile must be opened as a text file and encoding is specified.
Then it can accept a string. Current behaviour we get,

 Message: 'ok 2834 sequential/test-worker-prof'
 Arguments: ()
 --- Logging error ---
 Traceback (most recent call last):
   File "/usr/lib64/python3.7/logging/__init__.py", line 1037, in emit
     stream.write(msg + self.terminator)
 TypeError: a bytes-like object is required, not 'str'
 Call stack:
   File "tools/test.py", line 1734, in <module>
     sys.exit(Main())
   File "tools/test.py", line 1710, in Main
     if RunTestCases(cases_to_run, options.progress, options.j, options.flaky_tests):
   File "tools/test.py", line 933, in RunTestCases
     return progress.Run(tasks)
   File "tools/test.py", line 141, in Run
     self.RunSingle(False, 0)
   File "tools/test.py", line 202, in RunSingle
     self.HasRun(output)
   File "tools/test.py", line 365, in HasRun
     logger.info('  ---')

PR-URL: #31156
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #31224
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #31224
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #31236
Refs: #31187
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This requires minor changes to src/env.cc to deal with
`node::tracing::AgentWriterHandle::GetTracingController()` now possibly
returning a nullptr, because the cctest doesn't set one.

It seems plausible to me that embedders won't set one either so that
seems like an okay change to make. It avoids embedders having to track
down nullptr segfaults.

PR-URL: #31245
Refs: #31217
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This API method was introduced in commit 90ae4bd ("src: add
InitializeV8Platform function") from July 2018 but wasn't properly
exported and therefore not usable on Windows or with shared library
builds.

The motivation from the commit log is mainly about making it easier
to wire up the cctests and there are better ways to do that.

Refs: #31217

PR-URL: #31245
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This symlink loop was originally intended to be accessed from
a test. Instead, a loop is created by the test itself, but this
was unfortunately forgotten about. It's unused, so remove it.

PR-URL: #31267
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Test that using --insecure-http-parser will disable validation of
invalid characters in HTTP headers.

See:
- #30567

PR-URL: #31253
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Previously folders were created in the root of the project and would
therefore stay there in case of errors. This changes the test to create
all directories in the temp directory (`tmpdir.path`).

PR-URL: #31250
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
When operating on a FileHandle, the file has already been opened with
the flag given as an option to fs.promises.open(). This means defaulting
to 'a' has no effect here, and FileHandle#appendFile turns out to
exactly be an alias of writeFile. This is now explicit, saving a stack
frame, object copy and assignment.

PR-URL: #31235
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
* Remove `mode` and `flag` options for all three functions, since they
all ignore those options.
* Remove mention of `path` argument for `readFile`, since it isn't
actually an option to this method.
* Clarify that for file handles, `appendFile` and `writeFile` are
equivalent.

PR-URL: #31235
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
PR-URL: #31153
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #31254
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The for await loop into writable loop could cause an unhandled exception
in the case where we are waiting for data from the async iterable and
this no `'error'` handler is registered on the writable.

Fixes: #31222

PR-URL: #31252
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
guybedford and others added 2 commits January 20, 2020 21:45
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: #31001 (comment)

PR-URL: #31427
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@nodejs nodejs deleted a comment from nodejs-github-bot Jan 21, 2020
@richardlau richardlau dismissed their stale review January 21, 2020 06:05

fix has been cherry-picked

@richardlau
Copy link
Member

@codebytere FYI the two cherry-picked commits are missing from the updates to CHANGELOG_V13.md.

@codebytere
Copy link
Member Author

ah, dangit, thanks for the catch @richardlau

Notable changes:

* deps:
  * upgrade to libuv 1.34.1 (cjihrig) #31332
  * upgrade npm to 6.13.6 (Ruy Adorno) #31304
* module
  * add API for interacting with source maps (bcoe) #31132
  * loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
  * logical conditional exports ordering (Guy Bedford) #31008
  * unflag conditional exports (Guy Bedford) #31001
* process:
  * allow monitoring uncaughtException (Gerhard Stoebich) #31257
* Added new collaborators:
  * [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. #31306

PR-URL: #31382
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2020

@nodejs nodejs deleted a comment from nodejs-github-bot Jan 21, 2020
@nodejs-github-bot
Copy link
Collaborator

@codebytere
Copy link
Member Author

The two failures are leftovers from aborted runs - otherwise i think we're good to go!

@codebytere codebytere merged commit bbab963 into v13.x Jan 21, 2020
codebytere added a commit that referenced this pull request Jan 21, 2020
codebytere added a commit that referenced this pull request Jan 21, 2020
Notable changes:

* deps:
  * upgrade to libuv 1.34.1 (cjihrig) #31332
  * upgrade npm to 6.13.6 (Ruy Adorno) #31304
* module
  * add API for interacting with source maps (bcoe) #31132
  * loader getSource, getFormat, transform hooks (Geoffrey Booth) #30986
  * logical conditional exports ordering (Guy Bedford) #31008
  * unflag conditional exports (Guy Bedford) #31001
* process:
  * allow monitoring uncaughtException (Gerhard Stoebich) #31257
* Added new collaborators:
  * [GeoffreyBooth](https://github.com/GeoffreyBooth) - Geoffrey Booth. #31306

PR-URL: #31382
@ljharb
Copy link
Member

ljharb commented Jan 21, 2020

@codebytere i don't see you in the build channel on slack or freenode; typically the release is announced in one of those as part of the checklist :-) also the blog post isn't up yet, is that coming?

@codebytere
Copy link
Member Author

@ljharb i'm still finishing up the release itself! so yes, as i work down the release step doc

codebytere added a commit to nodejs/nodejs.org that referenced this pull request Jan 21, 2020
codebytere added a commit to nodejs/nodejs.org that referenced this pull request Jan 21, 2020
@codebytere codebytere deleted the v13.7.0-proposal branch January 21, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.