v13.7.0 proposal

.eslintrc.js

@@ -244,6 +244,10 @@ module.exports = {
         selector: "CallExpression[callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
         message: 'The first argument should be the `actual`, not the `expected` value.',
       },
+      {
+        selector: "CallExpression[callee.name='isNaN']",
+        message: 'Use Number.isNaN() instead of the global isNaN() function.',
+      },
     ],
     /* eslint-enable max-len */
     'no-return-await': 'error',

.github/workflows/CI.yml

@@ -0,0 +1,79 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  build-linux:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js 13
+        uses: actions/setup-node@v1
+        with:
+          node-version: 13.x
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: ./configure && make -j2
+  build-windows:
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js 13
+        uses: actions/setup-node@v1
+        with:
+          node-version: 13.x
+      - name: Environment Information
+        run: npx envinfo
+      - name: Install deps
+        run: choco install nasm
+      - name: Build
+        run: ./vcbuild.bat
+  build-macOS:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js 13
+        uses: actions/setup-node@v1
+        with:
+          node-version: 13.x
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: ./configure && make -j8
+  lint-addon-docs:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js 10
+      uses: actions/setup-node@v1
+      with:
+        node-version: 10.x
+    - name: Lint addon docs
+      run: NODE=$(which node) make lint-addon-docs
+  lint-cpp:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Lint C/C++ files
+      run: make lint-cpp
+  lint-md:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js 10
+      uses: actions/setup-node@v1
+      with:
+        node-version: 10.x
+    - name: Lint docs
+      run: NODE=$(which node) make lint-md
+  lint-js:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js 10
+      uses: actions/setup-node@v1
+      with:
+        node-version: 10.x
+    - name: Lint JavaScript files
+      run: NODE=$(which node) make lint-js

.github/workflows/pythonpackage.yml

@@ -0,0 +1,33 @@
+name: Python 3 testing
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      max-parallel: 1
+      matrix:
+        python-version: [3.8]  # [2.7, 3.5, 3.6, 3.7]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v1
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Compile Node.js
+      run: |
+        python ./configure.py
+        make -j2 V=1
+    - name: Test JS Suites
+      run: |
+        python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare default
+    - name: Test C++ Suites
+      run: |
+        make -j1 V=1 test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
+        python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare addons js-native-api node-api
+    - name: Make lint
+      run: |
+        make lint-py-build || true
+        NODE=$(which node) make lint lint-py

CHANGELOG.md

@@ -30,7 +30,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V13.md#13.6.0">13.6.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V13.md#13.7.0">13.7.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V13.md#13.6.0">13.6.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.5.0">13.5.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.4.0">13.4.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.3.0">13.3.0</a><br/>

README.md

@@ -8,8 +8,9 @@
   </a>
 </p>
 
-Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine. For
-more information on using Node.js, see the [Node.js Website][].
+Node.js is an open-source, cross-platform, JavaScript runtime environment. It
+executes JavaScript code outside of a browser. For more information on using
+Node.js, see the [Node.js Website][].
 
 The Node.js project uses an [open governance model](./GOVERNANCE.md). The
 [OpenJS Foundation][] provides support for the project.
@@ -302,6 +303,8 @@ For information about the governance of the Node.js project, see
 **Wyatt Preul** &lt;wpreul@gmail.com&gt;
 * [gengjiawen](https://github.com/gengjiawen) -
 **Jiawen Geng** &lt;technicalcute@gmail.com&gt;
+* [GeoffreyBooth](https://github.com/geoffreybooth) -
+**Geoffrey Booth** &lt;webmaster@geoffreybooth.com&gt; (he/him)
 * [gibfahn](https://github.com/gibfahn) -
 **Gibson Fahnestock** &lt;gibfahn@gmail.com&gt; (he/him)
 * [gireeshpunathil](https://github.com/gireeshpunathil) -

benchmark/async_hooks/http-server.js

@@ -26,15 +26,15 @@ function main({ asyncHooks, connections }) {
     }
   }
   const server = require('../fixtures/simple-http-server.js')
-  .listen(common.PORT)
-  .on('listening', () => {
-    const path = '/buffer/4/4/normal/1';
+    .listen(common.PORT)
+    .on('listening', () => {
+      const path = '/buffer/4/4/normal/1';
 
-    bench.http({
-      connections,
-      path,
-    }, () => {
-      server.close();
+      bench.http({
+        connections,
+        path,
+      }, () => {
+        server.close();
+      });
     });
-  });
 }

benchmark/async_hooks/promises.js

@@ -0,0 +1,30 @@
+'use strict';
+const common = require('../common.js');
+const { createHook } = require('async_hooks');
+
+const bench = common.createBenchmark(main, {
+  n: [1e6],
+  asyncHooks: [
+    'enabled',
+    'disabled',
+  ]
+});
+
+async function run(n) {
+  for (let i = 0; i < n; i++) {
+    await new Promise((resolve) => resolve())
+      .then(() => { throw new Error('foobar'); })
+      .catch((e) => e);
+  }
+}
+
+function main({ n, asyncHooks }) {
+  const hook = createHook({ promiseResolve() {} });
+  if (asyncHooks !== 'disabled') {
+    hook.enable();
+  }
+  bench.start();
+  run(n).then(() => {
+    bench.end(n);
+  });
+}

benchmark/misc/getstringwidth.js

@@ -10,6 +10,8 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, type }) {
+  // Default value for testing purposes.
+  type = type || 'ascii';
   const { getStringWidth } = require('internal/readline/utils');
 
   const str = ({

common.gypi

@@ -39,7 +39,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.26',
+    'v8_embedder_string': '-node.28',
 
     ##### V8 defaults for Node.js #####
 

configure.py

@@ -1540,8 +1540,11 @@ def write_config(data, name):
     os.mkdir(icu_tmp_path)
     icu_data_path = os.path.join(icu_tmp_path, icu_data_file_l)
     with open(icu_data_path, 'wb') as outf:
-        with bz2.BZ2File(compressed_data, 'rb') as inf:
-            shutil.copyfileobj(inf, outf)
+        inf = bz2.BZ2File(compressed_data, 'rb')
+        try:
+          shutil.copyfileobj(inf, outf)
+        finally:
+          inf.close()
     # Now, proceed..
 
   # relative to dep..

deps/cares/cares.gyp

@@ -112,7 +112,10 @@
           'defines': [ 'CARES_BUILDING_LIBRARY' ]
         }],
         [ 'OS=="win"', {
-          'defines': [ 'CARES_PULL_WS2TCPIP_H=1' ],
+          'defines': [
+            'CARES_PULL_WS2TCPIP_H=1',
+            '_WINSOCK_DEPRECATED_NO_WARNINGS',
+          ],
           'include_dirs': [ 'config/win32' ],
           'sources': [
             'src/config-win32.h',

deps/npm/.travis.yml

@@ -2,46 +2,16 @@
 language: node_js
 
 os:
-  - linux
+  - windows
 
 node_js:
   - 12
   - 10
   - 8
+  - 6
 
 env: "DEPLOY_VERSION=testing"
 
-# having top-level `env:` adds a phantom build
-# https://github.com/travis-ci/travis-ci/issues/4681
-#env: DEPLOY_VERSION=testing
-matrix:
-  include:
-    # Run the sudotest, but only on Linux
-    - node_js: "12"
-      # DEPLOY_VERSION is used to set the couchapp setup mode for test/tap/registry.js
-      # only gather coverage info for LTS
-      env: DEPLOY_VERSION=testing COVERALLS_REPO_TOKEN="$COVERALLS_OPTIONAL_TOKEN"
-      script:
-        # run the sudo tests, with coverage enabled
-        - "sudo PATH=$PATH $(which node) . run tap -- \"test/tap/*.js\" --coverage  --timeout 600"
-
-    # also run standard and license checking
-    - node_js: "10"
-      script:
-        - "npx standard"
-        - "node . run licenses"
-
-    # separate out node 6 so we can turn off caching, because that
-    # always breaks for some reason.
-    - node_js: "6"
-      cache: false
-      env: "DEPLOY_VERSION=testing"
-
-    # only run one test on Windows, because it's hella slow
-    - node_js: "12"
-      os: "windows"
-      env: "DEPLOY_VERSION=testing"
-
 notifications:
     slack: npm-inc:kRqQjto7YbINqHPb1X6nS3g8
 

deps/npm/AUTHORS

@@ -677,3 +677,7 @@ Fighting-Jack <574637316@qq.com>
 Bakel, Roel van <roel.vanbakel@oce.com>
 Charlie West-Toebe <38671683+Hoidberg@users.noreply.github.com>
 Richard Lau <riclau@uk.ibm.com>
+Felix Yan <felixonmars@archlinux.org>
+Zhenya Vinogradov <zhenyavinogradov@gmail.com>
+Rafael Hengles <rhengles@gmail.com>
+Jan-Philip Gehrcke <jp@opstrace.com>

deps/npm/CHANGELOG.md

@@ -1,3 +1,35 @@
+## 6.13.6 (2020-01-09)
+
+### DEPENDENCIES
+
+* [`6dba897a1`](https://github.com/npm/cli/commit/6dba897a1e2d56388fb6df0c814b0bb85af366b4)
+  `pacote@9.5.12`:
+    * [`d2f4176`](https://github.com/npm/pacote/commit/d2f4176b6af393d7e29de27e9b638dbcbab9a0c7)
+      fix(git): Do not drop uid/gid when executing in root-owned directory
+      ([@isaacs](https://github.com/isaacs))
+
+## 6.13.5 (2020-01-09)
+
+### BUG FIXES
+
+* [`fd0a802ec`](https://github.com/npm/cli/commit/fd0a802ec468ec7b98d6c15934c355fef0e7ff60) [#550](https://github.com/npm/cli/pull/550) Fix cache location for `npm ci` ([@zhenyavinogradov](https://github.com/zhenyavinogradov))
+* [`4b30f3cca`](https://github.com/npm/cli/commit/4b30f3ccaebf50d6ab3bad130ff94827c017cc16) [#648](https://github.com/npm/cli/pull/648) fix(version): using 'allow-same-version', git commit --allow-empty and git tag -f ([@rhengles](https://github.com/rhengles))
+
+### TESTING
+
+* [`e16f68d30`](https://github.com/npm/cli/commit/e16f68d30d59ce1ddde9fe62f7681b2c07fce84d) test(ci): add failing cache config test ([@ruyadorno](https://github.com/ruyadorno))
+* [`3f009fbf2`](https://github.com/npm/cli/commit/3f009fbf2c42f68c5127efecc6e22db105a74fe0) [#659](https://github.com/npm/cli/pull/659) test: fix bin-overwriting test on Windows ([@isaacs](https://github.com/isaacs))
+* [`43ae0791f`](https://github.com/npm/cli/commit/43ae0791f74f68e02850201a64a6af693657b241) [#601](https://github.com/npm/cli/pull/601) ci: Allow builds to run even if one fails ([@XhmikosR](https://github.com/XhmikosR))
+* [`4a669bee4`](https://github.com/npm/cli/commit/4a669bee4ac54c70adc6979d45cd0605b6dc33fd) [#603](https://github.com/npm/cli/pull/603) Remove the unused appveyor.yml ([@XhmikosR](https://github.com/XhmikosR))
+* [`9295046ac`](https://github.com/npm/cli/commit/9295046ac92bbe82f4d84e1ec90cc81d3b80bfc7) [#600](https://github.com/npm/cli/pull/600) ci: switch to `actions/checkout@v2` ([@XhmikosR](https://github.com/XhmikosR))
+
+### DOCUMENTATION
+
+* [`f2d770ac7`](https://github.com/npm/cli/commit/f2d770ac768ea84867772b90a3c9acbdd0c1cb6a) [#569](https://github.com/npm/cli/pull/569) fix netlify publish path config ([@claudiahdz](https://github.com/claudiahdz))
+* [`462cf0983`](https://github.com/npm/cli/commit/462cf0983dbc18a3d93f77212ca69f878060b2ec) [#627](https://github.com/npm/cli/pull/627) update gatsby dependencies ([@felixonmars](https://github.com/felixonmars))
+* [`6fb5dbb72`](https://github.com/npm/cli/commit/6fb5dbb7213c4c050c9a47a7d5131447b8b7dcc8)
+  [#532](https://github.com/npm/cli/pull/532) docs: clarify usage of global prefix ([@jgehrcke](https://github.com/jgehrcke))
+
 ## 6.13.4 (2019-12-11)
 
 ## BUGFIXES

deps/npm/docs/content/cli-commands/npm-link.md

@@ -23,8 +23,8 @@ Package linking is a two-step process.
 
 First, `npm link` in a package folder will create a symlink in the global folder
 `{prefix}/lib/node_modules/<package>` that links to the package where the `npm
-link` command was executed. (see [`npm-config`](npm-config) for the value of `prefix`). It
-will also link any bins in the package to `{prefix}/bin/{name}`.
+link` command was executed. It will also link any bins in the package to `{prefix}/bin/{name}`.
+Note that `npm link` uses the global prefix (see `npm prefix -g` for its value).
 
 Next, in some other location, `npm link package-name` will create a
 symbolic link from globally-installed `package-name` to `node_modules/`