New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: ask more questions in the bug report template #31611

Closed

joyeecheung wants to merge 2 commits into nodejs:master from joyeecheung:template

Member

joyeecheung commented Feb 2, 2020

Inspired by the defect report template of the V8 issue tracker

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines


          doc: ask more questions in the bug report template

fda37e2

Inspired by the defect report template of the V8 issue tracker

nodejs-github-bot added the meta label

bnoordhuis approved these changes

View reviewed changes

gireeshpunathil approved these changes

View reviewed changes

Trott reviewed

View reviewed changes

.github/ISSUE_TEMPLATE.md Show resolved Hide resolved

Trott approved these changes

View reviewed changes

Member

Trott left a comment •

edited

Loading

I default to not wanting to make these templates longer, but I think the "steps to reproduce", "expected results", and "what you see instead" stuff has become pretty standard and people will immediately know what it is. LGTM. Thanks!

cjihrig approved these changes

View reviewed changes

starkwang approved these changes

View reviewed changes

jasnell approved these changes

View reviewed changes

lpinca approved these changes

View reviewed changes


          Update .github/ISSUE_TEMPLATE.md

Co-Authored-By: Rich Trott <rtrott@gmail.com>

watilde approved these changes

View reviewed changes

tniessen approved these changes

View reviewed changes

joyeecheung added a commit that referenced this pull request


          doc: ask more questions in the bug report template

0effc98

Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Member Author

joyeecheung commented Feb 6, 2020

Landed in 0effc98

joyeecheung closed this

joyeecheung mentioned this pull request

doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder #31656

Closed

4 tasks

Member Author

joyeecheung commented Feb 6, 2020

Just noticed that this change is not in effect because it changed the obsolete .github/ISSUE_TEMPLATE.md while the file in effect is .github/ISSUE_TEMPLATE/1-bug-report.md. Opened #31656

Trott pushed a commit that referenced this pull request


          doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder

e2a3a87

This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere pushed a commit that referenced this pull request


          doc: ask more questions in the bug report template

e27f249

Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

codebytere pushed a commit that referenced this pull request


          doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder

2e6c737

This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere mentioned this pull request

v13.9.0 proposal #31837

Merged

codebytere pushed a commit that referenced this pull request


          doc: ask more questions in the bug report template

73c0986

Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

codebytere pushed a commit that referenced this pull request


          doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder

44235db

This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere pushed a commit that referenced this pull request


          doc: ask more questions in the bug report template

ea4f266

Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

codebytere pushed a commit that referenced this pull request


          doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder

aeadd68

This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere mentioned this pull request

v12.16.2 proposal #32313

Merged

codebytere pushed a commit that referenced this pull request


          doc: ask more questions in the bug report template

afeaec7

Inspired by the defect report template of the V8 issue tracker

PR-URL: #31611
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

codebytere pushed a commit that referenced this pull request


          doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder

76b5002

This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

starkwang starkwang approved these changes

gireeshpunathil gireeshpunathil approved these changes

tniessen tniessen approved these changes

cjihrig cjihrig approved these changes

watilde watilde approved these changes

lpinca lpinca approved these changes

Trott Trott approved these changes

jasnell jasnell approved these changes

bnoordhuis bnoordhuis approved these changes

Labels

meta