-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder #31656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect.
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Feb 6, 2020
4 tasks
Trott
reviewed
Feb 6, 2020
|
||
Please fill in as much of the template below as you can. | ||
This issue tracker is for bugs and issues found within Node.js core. | ||
If you require more general support please file an issue on our help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
If you require more general support please file an issue on our help | |
If you require more general support, please file an issue on our help |
Trott
approved these changes
Feb 6, 2020
jasnell
approved these changes
Feb 6, 2020
BridgeAR
approved these changes
Feb 6, 2020
lpinca
approved these changes
Feb 6, 2020
cjihrig
approved these changes
Feb 7, 2020
Trott
pushed a commit
that referenced
this pull request
Feb 7, 2020
This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: #31656 Refs: #31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in e2a3a87 |
I goofed and landed this early, but rather than force-push it out, I'd prefer to retroactively get fast-track approval. Sorry about the error. Any Collaborators want to 👍 this to fast-track? |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: #31656 Refs: #31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: #31656 Refs: #31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: #31656 Refs: #31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
This removes the obsolete issue template file since we already have the issue template folder which is the one currently in effect. PR-URL: #31656 Refs: #31611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.
Refs: #31611
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes