Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder #31656

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

Refs: #31611

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 6, 2020

Please fill in as much of the template below as you can.
This issue tracker is for bugs and issues found within Node.js core.
If you require more general support please file an issue on our help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you require more general support please file an issue on our help
If you require more general support, please file an issue on our help

Trott pushed a commit that referenced this pull request Feb 7, 2020
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Feb 7, 2020

Landed in e2a3a87

@Trott Trott closed this Feb 7, 2020
@Trott
Copy link
Member

Trott commented Feb 7, 2020

I goofed and landed this early, but rather than force-push it out, I'd prefer to retroactively get fast-track approval. Sorry about the error. Any Collaborators want to 👍 this to fast-track?

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 7, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
This removes the obsolete issue template file since we already
have the issue template folder which is the one currently in effect.

PR-URL: #31656
Refs: #31611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants