test: improve assertion message in test-dns-any #31697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 8, 2020
The test failed in CI but this time with a useful message: So I consider that a ✅. |
Trott
added
the
author ready
cjihrig
approved these changes
Feb 9, 2020
BridgeAR
approved these changes
Feb 9, 2020
jasnell
approved these changes
Feb 10, 2020
Improve error message from "The expression evaluated to a falsy value" to a message formatted dynamically that lists the record types found so that someone investigating can look at the code and determine which values are missing. This came up because the test failed in nightly master branch CI but generally passes. It may prove helpful to know what record types were missing. (All of them? Just one? Something else?) PR-URL: nodejs#31697 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
force-pushed
the
improve-message
branch
from
fbfefb9
to
84836df
Compare
|
Landed in 84836df |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
Improve error message from "The expression evaluated to a falsy value" to a message formatted dynamically that lists the record types found so that someone investigating can look at the code and determine which values are missing. This came up because the test failed in nightly master branch CI but generally passes. It may prove helpful to know what record types were missing. (All of them? Just one? Something else?) PR-URL: #31697 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Improve error message from "The expression evaluated to a falsy value" to a message formatted dynamically that lists the record types found so that someone investigating can look at the code and determine which values are missing. This came up because the test failed in nightly master branch CI but generally passes. It may prove helpful to know what record types were missing. (All of them? Just one? Something else?) PR-URL: #31697 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Improve error message from "The expression evaluated to a falsy value" to a message formatted dynamically that lists the record types found so that someone investigating can look at the code and determine which values are missing. This came up because the test failed in nightly master branch CI but generally passes. It may prove helpful to know what record types were missing. (All of them? Just one? Something else?) PR-URL: #31697 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Improve error message from "The expression evaluated to a falsy value" to a message formatted dynamically that lists the record types found so that someone investigating can look at the code and determine which values are missing. This came up because the test failed in nightly master branch CI but generally passes. It may prove helpful to know what record types were missing. (All of them? Just one? Something else?) PR-URL: #31697 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message from "The expression evaluated to a falsy value"
to a message formatted dynamically that lists the record types found so
that someone investigating can look at the code and determine which
values are missing.
This came up because the test failed in nightly master branch CI but
generally passes. It may prove helpful to know what record types were
missing. (All of them? Just one? Something else?)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes