Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve assertion message in test-dns-any #31697

Merged
merged 1 commit into from
Feb 10, 2020

Commits on Feb 10, 2020

  1. test: improve assertion message in test-dns-any

    Improve error message from "The expression evaluated to a falsy value"
    to a message formatted dynamically that lists the record types found so
    that someone investigating can look at the code and determine which
    values are missing.
    
    This came up because the test failed in nightly master branch CI but
    generally passes. It may prove helpful to know what record types were
    missing. (All of them? Just one? Something else?)
    
    PR-URL: nodejs#31697
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    84836df View commit details
    Browse the repository at this point in the history