-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade to c-ares v1.16.0 #32246
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
cares
Issues and PRs related to the c-ares dependency or the cares_wrap binding.
label
Mar 13, 2020
CI: https://ci.nodejs.org/job/node-test-pull-request/29800/ (:white_check_mark:) |
cjihrig
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubberstamp LGTM
jasnell
approved these changes
Mar 13, 2020
addaleax
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 13, 2020
devnexen
approved these changes
Mar 14, 2020
Landed in 4cfcaae |
addaleax
added a commit
that referenced
this pull request
Mar 20, 2020
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0 PR-URL: #32246 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0 PR-URL: #32246 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0 PR-URL: #32246 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
targos
added a commit
that referenced
this pull request
Apr 24, 2020
Notable changes: Dependencies: * Updated OpenSSL to 1.1.1f. #32583 * Updated c-ares to 1.16.0. #32246 * Updated experimental uvwasi to 0.0.6. #32309 ESM (experimental): * Additional warnings are no longer printed for modules that use conditional exports or package name self resolution. #31845 PR-URL: #33009
targos
added a commit
that referenced
this pull request
Apr 27, 2020
Notable changes: Dependencies: * Updated OpenSSL to 1.1.1f. #32583 * Updated c-ares to 1.16.0. #32246 * Updated experimental uvwasi to 0.0.6. #32309 ESM (experimental): * Additional warnings are no longer printed for modules that use conditional exports or package name self resolution. #31845 PR-URL: #33009
targos
added a commit
that referenced
this pull request
Apr 27, 2020
Notable changes: Dependencies: * Updated OpenSSL to 1.1.1g. #32971 * Updated c-ares to 1.16.0. #32246 * Updated experimental uvwasi to 0.0.6. #32309 ESM (experimental): * Additional warnings are no longer printed for modules that use conditional exports or package name self resolution. #31845 PR-URL: #33009
targos
added a commit
that referenced
this pull request
Apr 28, 2020
Notable changes: Dependencies: * Updated OpenSSL to 1.1.1g. #32971 * Updated c-ares to 1.16.0. #32246 * Updated experimental uvwasi to 0.0.6. #32309 ESM (experimental): * Additional warnings are no longer printed for modules that use conditional exports or package name self resolution. #31845 PR-URL: #33009
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 29, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
cares
Issues and PRs related to the c-ares dependency or the cares_wrap binding.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes