-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v13.12.0 proposal #32376
v13.12.0 proposal #32376
Conversation
Missing from release, apologies. PR-URL: #32218 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Thinking we should release this next tuesday with the 10.x and 12.x releases. We should likely include a couple of Streams related backports and the update to OpenSSL |
Please highlight in the notable changes that this is the first notarized release for macOS and that we needed to change the release environment to do that (so there is a small risk). @rvagg / @AshCripps did we come up with some text for @nodejs/releasers to include in the release notes? (and on that note, do we need to reapply d2f08a1? It looks like #32368 has overwritten the signed binary.) |
re macOS change in builders, I shared my proposal for text in #32243 (comment) |
And yes, I thought the term-size binary update would come in via npm but maybe they haven't updated that dep yet, so I suppose it needs to be re-applied. The release build will fail if it's not signed. If that's on v13.x-staging then we'll see in a few hours if the nightly fails. |
I personally would publish the release as soon as possible and not wait for the other release lines. |
@BridgeAR Not sure if that’s what you’re saying, but I think this is not a good time for Friday or weekend releases, thinking along the lines of nodejs/Release#553 (not that those are really ever a good idea) |
@addaleax I do not think we should hold of a current releases as I outlined in nodejs/Release#553. Reducing the number of LTS releases seems reasonable though. |
Timing isn't really as big a deal for Current, we don't expect large installations to be using it in production (and if you are, then you're running on YOLO anyway). Whoever does this release, can you please rebase and put my 3 notarization commits after the npm update so term-size is updated properly (that's in one commit but it'd be nice if the 3 stay together). |
Have documented the need to add a signed term-size on top of an npm update in #32403, as I said there, I'm not hopeful that we'll see an updated dep tree in short order, hence the need to prepare to do this repeatedly in the future. |
given that #32328 hasn't landed yet and we will likely want to include it in this release should we consider delaying by a week? Is there anything in this release super time sensitive? |
I sent an email to inactive collaborators (in the previous 6 months at the time, no commits, no PRs reviewed, and no commits landed) asking if it was time to move to emeritus. Some replied affirmatively and I have moved those people to emeritus. Others replied indicating a desire to remain collaborators, and I left them as collaborators. The remaining folks are being moved to emeritus in this change. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #32151 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32213 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #32037 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: #32072 PR-URL: #32073 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #32087 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #32125 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: #30056 PR-URL: #30147 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Define `util.promisify.custom` as `Symbol.for("nodejs.util.inspect.custom")`, rather than as `Symbol("util.inspect.custom")`. This allows custom `promisify` wrappers to easily/safely be defined in non‑Node.js environments. Fixes: #31647 PR-URL: #31672 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
27dbe1f
to
9b41258
Compare
macOS package notarization and a change in builder configuration: The macOS binaries for this release, and future 13.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing on .pkg files on macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being compiled to support a minimum of macOS 10.10 (Yosemite) we do not anticipate this having a negative impact on Node.js 13.x users with older versions of macOS. Notable changes: * build: * macOS package notarization (Rod Vagg) #31459 * deps: * update npm to 6.14.3 (Myles Borins) #32368 * update to uvwasi 0.0.6 (Colin Ihrig) #32309 * upgrade to libuv 1.35.0 (Colin Ihrig) #32204 * lib: * add --disable-proto option to cli (Gus Caplan) #32279 * node_report: * move diagnostic reports to stable (Colin Ihrig) #32242 * worker: * allow URL in Worker constructor (Antoine du HAMEL) #31664 * util: * use a global symbol for `util.promisify.custom` (ExE Boss) #31672 PR-URL: #32376
9b41258
to
a87ac59
Compare
It would be awesome to have this onboard #32476 👀 |
It would be good to get this out sooner than later. These notarization hangups are becoming a hassle and we need to have it out in a 13.x before we can backport to 10.x and 12.x. e.g. discussion in nodejs/build#2188 re Apple becoming even more strict this month on Catalina. |
`ObjectTemplate`s are not garbage-collected like regular objects (for some reason). It is sufficient to create a single template anyway, so do that to address the memory leak. Fixes: #32424 PR-URL: #32426 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #32385 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Instead of indicating that examples show lines to change in previous examples, present the examples as standalone items. They suffice on their own. In the first of these, it says to change "the second line" of a previous example, but if it were literally changed to the provided line, it would result in a syntax error. In the second of these, it gives the wrong line to change. All of this is unnecessary and probably makes the examples harder to follow. So simplify and treat each one as a separate example. PR-URL: #32451 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Typo `runAndReturn` -> `runSyncAndReturn` PR-URL: #32382 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. PR-URL: #32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Since the previous sentence describes `10` as a default, and the following sentence explains how to modify that default, it is unnecessary to explain that "Obviously, not all events should be limited to just 10 listeners." PR-URL: #32457 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #32495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host>
macOS package notarization and a change in builder configuration: The macOS binaries for this release, and future 13.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing on .pkg files on macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being compiled to support a minimum of macOS 10.10 (Yosemite) we do not anticipate this having a negative impact on Node.js 13.x users with older versions of macOS. Notable changes: * build: * macOS package notarization (Rod Vagg) #31459 * deps: * upgrade npm to 6.14.4 (Ruy Adorno) #32495 * update to uvwasi 0.0.6 (Colin Ihrig) #32309 * upgrade to libuv 1.35.0 (Colin Ihrig) #32204 * lib: * add --disable-proto option to cli (Gus Caplan) #32279 * node_report: * move diagnostic reports to stable (Colin Ihrig) #32242 * worker: * allow URL in Worker constructor (Antoine du HAMEL) #31664 * util: * use a global symbol for `util.promisify.custom` (ExE Boss) #31672 PR-URL: #32376
a87ac59
to
65782ff
Compare
macOS package notarization and a change in builder configuration: The macOS binaries for this release, and future 13.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing on .pkg files on macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being compiled to support a minimum of macOS 10.10 (Yosemite) we do not anticipate this having a negative impact on Node.js 13.x users with older versions of macOS. Notable changes: * build: * macOS package notarization (Rod Vagg) #31459 * deps: * upgrade npm to 6.14.4 (Ruy Adorno) #32495 * update to uvwasi 0.0.6 (Colin Ihrig) #32309 * upgrade to libuv 1.35.0 (Colin Ihrig) #32204 * lib: * add --disable-proto option to cli (Gus Caplan) #32279 * node_report: * move diagnostic reports to stable (Colin Ihrig) #32242 * worker: * allow URL in Worker constructor (Antoine du HAMEL) #31664 * util: * use a global symbol for `util.promisify.custom` (ExE Boss) #31672 PR-URL: #32376
65782ff
to
f6a339f
Compare
CI: https://ci.nodejs.org/job/node-test-pull-request/30104/ |
CI: https://ci.nodejs.org/job/node-test-pull-request/30109/ |
macOS package notarization and a change in builder configuration: The macOS binaries for this release, and future 13.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing on .pkg files on macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being compiled to support a minimum of macOS 10.10 (Yosemite) we do not anticipate this having a negative impact on Node.js 13.x users with older versions of macOS. Notable changes: * build: * macOS package notarization (Rod Vagg) #31459 * deps: * upgrade npm to 6.14.4 (Ruy Adorno) #32495 * update to uvwasi 0.0.6 (Colin Ihrig) #32309 * upgrade to libuv 1.35.0 (Colin Ihrig) #32204 * lib: * add --disable-proto option to cli (Gus Caplan) #32279 * node_report: * move diagnostic reports to stable (Colin Ihrig) #32242 * worker: * allow URL in Worker constructor (Antoine du HAMEL) #31664 * util: * use a global symbol for `util.promisify.custom` (ExE Boss) #31672 PR-URL: #32376
Release approved |
2020-03-26, Version 13.12.0 (Current), @MylesBorins
macOS package notarization and a change in builder configuration
The macOS binaries for this release, and future 13.x releases, are now being compiled on
macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for
installing on .pkg files on macOS 10.15 and later. Previous builds of Node.js 13.x were
compiled on macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being compiled
to support a minimum of macOS 10.10 (Yosemite) we do not anticipate this having a negative
impact on Node.js 13.x users with older versions of macOS.
Notable Changes
util.promisify.custom
(ExE Boss) #31672Commits
81183caa4c
] - build: annotate markdown lint failures in pull requests (Richard Lau) #32391f8a020e636
] - build: macOS package notarization (Rod Vagg) #3145985bdb424c2
] - Revert "build: add asan check in Github action" (Matheus Marchini) #323248ea5ffc033
] - build: expand ASAN acronym in configure help (Sam Roberts) #32325074c3c144f
] - (SEMVER-MINOR) build: make --without-report a no-op (Colin Ihrig) #3224296ad768dbc
] - (SEMVER-MINOR) build: remove node_report option in node.gyp (Colin Ihrig) #322422069c4e530
] - build: disable libstdc++ debug containers globally (Ben Noordhuis) #3014779fdc6bea3
] - cli: allow --huge-max-old-generation-size in NODE_OPTIONS (Anna Henningsen) #32251deab08bc4e
] - deps: upgrade npm to 6.14.4 (Ruy Adorno) #324956387cf88c2
] - deps: update term-size with signed version (Rod Vagg) #314598201704231
] - deps: remove *.pyc files from deps/npm (Ben Noordhuis) #32387eef4721174
] - deps: update npm to 6.14.3 (Myles Borins) #32368fbdc4f59f7
] - deps: upgrade npm to 6.14.1 (Isaac Z. Schlueter) #31977d640426c8b
] - deps: update archs files for OpenSSL-1.1.1e (Hassaan Pasha) #32328d719f87ad6
] - deps: adjust openssl configuration for 1.1.1e (Hassaan Pasha) #323283878d8dd2e
] - deps: upgrade openssl sources to 1.1.1e (Hassaan Pasha) #323282cb9f7acb6
] - deps: update to ICU 66.1 (Steven R. Loomis) #32348e16964ed22
] - deps: minor ICU fixes: maint docs/tool, downloader (Steven R. Loomis) #323473825afed74
] - deps: upgrade to c-ares v1.16.0 (Anna Henningsen) #322467904ecd245
] - deps: update to uvwasi 0.0.6 (Colin Ihrig) #32309bee126131a
] - deps: upgrade to libuv 1.35.0 (Colin Ihrig) #32204ae90bccb70
] - deps: V8: cherry-pick f9257802c1c0 (Matheus Marchini) #3218011ed1e6c86
] - deps,doc: move openssl maintenance guide to doc (Sam Roberts) #3220940a9289e53
] - doc: remove extraneous sentence in events.md (Rich Trott) #324576168bd5951
] - doc: remove unnecessary "obvious(ly)" modifiers in esm.md (Rich Trott) #324579fda9123b1
] - doc: trim wording in n-api.md text about exceptions (Rich Trott) #324573e002c3977
] - doc: update async_hooks.md (Victor) #323826693b40bd5
] - doc: simplify and correct example descriptions in net.md (Rich Trott) #32451b5e4adfb49
] - doc: add new TSC members (Michael Dawson) #3247399a7636443
] - doc: fix lint warning in doc/api/esm.md (Richard Lau) #32462dfcc3e8990
] - doc: improve wording in vm.md (Rich Trott) #32427bbea3f21ff
] - doc: improve wording in esm.md (Rich Trott) #324274ca30303a7
] - doc: import clarifications with links to MDN (Eric Dobbertin) #31479471a5d8b82
] - doc: add note re term-size commit on top of npm (Rod Vagg) #3240399f260f42a
] - doc: official macOS builds now on 10.15 + Xcode 11 (Rod Vagg) #31459569e555c2e
] - doc: update security release process (Sam Roberts) #31679d2ce8e9c99
] - doc: fix some 404 links (Thomas Watson Steen) #32200b8753466e5
] - doc: complete n-api version matrix (Gabriel Schulhof) #323042e1fb2b9af
] - (SEMVER-MINOR) doc: update stability of report features (Colin Ihrig) #32242597bcb530a
] - doc: update conditional exports recommendations (Guy Bedford) #320985080734301
] - doc: expand fs.watch caveats (Bartosz Sosnowski) #3217619fee761ba
] - doc: add Ruben to TSC (Michael Dawson) #32213c72a678d0c
] - doc: add missing link for v13.11.0 changelog (Myles Borins) #32218cd388b25f6
] - (SEMVER-MINOR) doc,lib,src,test: make --experimental-report a nop (Colin Ihrig) #3224271a2fa24da
] - errors: drop pronouns from ERR_WORKER_PATH message (Colin Ihrig) #322853e9012a3da
] - esm: port loader code to JS (Anna Henningsen) #32201ef32069d0c
] - http: don't emit 'finish' after 'error' (Robert Nagy) #32276d2fea9fb4a
] - http2: rename counter inmapToHeaders
inner loop (Mateusz Krawczuk) #3201236ba54e8e1
] - lib: add option to disable __proto__ (Gus Caplan) #32279435341a94f
] - lib: use spread operator on cluster (himself65) #32125cd0982ae7c
] - lib: change var to let/const (himself65) #32037397cbca720
] - meta: move inactive collaborators to emeriti (Rich Trott) #321517356c43997
] - module: add hook for global preload code (Jan Krems) #3206859a21e28d6
] - n-api: fix comment on expected N-API version (Michael Dawson) #322361ecd407a71
] - repl: align preview with the actual executed code (Ruben Bridgewater) #3215428e298f219
] - report: handle on-fatalerror better (Harshitha KP) #3220794952b4ac8
] - src: enhance C++ sprintf utility (himself65) #32385e9e12b8f36
] - src: use single ObjectTemplate for TextDecoder (Anna Henningsen) #324266f06cf0bf4
] - src: delete BaseObjectWeakPtr data when pointee is gone (Anna Henningsen) #323932bcf535a05
] - src: simplify IsolateData shortcut accesses (Anna Henningsen) #324072fe351f6c3
] - src: delete CallbackInfo when cleared from cleanup hook (Anna Henningsen) #32405bd55a9a607
] - src: avoid Isolate::GetCurrent() for platform implementation (Anna Henningsen) #3226911650c683e
] - src: update comment for SetImmediate() (Anna Henningsen) #32300243d0d4716
] - src: add debug option to report large page stats (Gabriel Schulhof) #32331f873d87a7f
] - src: prefer OnScopeLeave over shared_ptr<void> (Anna Henningsen) #322471c4a112fcc
] - src: clean up stream_base.h and stream-base-inl.h (James M Snell) #323071476182670
] - src: handle NULL env scenario (himself65) #322301950c08ab1
] - (SEMVER-MINOR) src: unconditionally include report feature (Colin Ihrig) #32242c00ce7b708
] - src: find .text section using dl_iterate_phdr (Gabriel Schulhof) #322447fc5e6d37b
] - src: fix warn_unused_result compiler warning (Colin Ihrig) #32241d497f268f2
] - src: refactor to more safe method (gengjiawen) #32087b5b7bf5ea4
] - src,cli: support compact (one-line) JSON reports (Sam Roberts) #3225456da8dfd86
] - stream: emit 'pause' on unpipe (Robert Nagy) #32476b7a8878f0c
] - stream: fix pipeline with dest in objectMode (Robert Nagy) #324140185e3a46c
] - stream: add pipeline test for destroy of returned stream (Robert Nagy) #3242523ba0889ce
] - stream: don't emit 'finish' after 'error' (Robert Nagy) #3227507e41311d0
] - test: refactoring / cleanup on child-process tests (James M Snell) #320782f73e6eee0
] - test: use mustCall in place of countdown in timers test (Rich Trott) #3241676a7386eff
] - test: end tls connection with some data (Sam Roberts) #32328fcf9b46d55
] - test: discard data received by client (Hassaan Pasha) #323282e287837f8
] - test: replace countdown with Promise.all() in cluster-net-listen tests (Rich Trott) #32381bdcc11f167
] - test: replace Map with Array in cluster-net-listen tests (Rich Trott) #323814d173ea7d6
] - test: uv_tty_init returns EBADF on IBM i (Xu Meng) #3233805fd16048c
] - test: use Promise.all() in test-hash-seed (Rich Trott) #3227376781bd16e
] - (SEMVER-MINOR) test: remove common.skipIfReportDisabled() (Colin Ihrig) #32242df1d4f708f
] - test: workaround for V8 8.1 inspector pause issue (Matheus Marchini) #32234fbcf602823
] - test: make test-memory-usage predictable (Matheus Marchini) #3223909ca76befa
] - test: verify that WASI errors are rethrown (Colin Ihrig) #32157fd80c21e9c
] - test: add new scenario for async-local storage (Harshitha KP) #32082c0af3acc52
] - test: use portable EOL (Harshitha KP) #32104ed83a1cc09
] - test: refactor and simplify test-repl-preview (Ruben Bridgewater) #3215408edf53207
] - test:buffer.write
with longer string scenario (Harshitha KP) #321232262e7c26d
] - test: fix test-tls-env-extra-ca-file-load (Eric Bickle) #32073dedd219622
] - tools: fixup icutrim.py use of string and bytes objects (Jonathan MERCIER) #316595adaf1092a
] - tools: update minimist@1.2.5 (Rich Trott) #32274963ce088fc
] - tools: update to acorn@7.1.1 (Rich Trott) #32259fa1fa3111a
] - util: text decoding allows SharedArrayBuffer (Bradley Farias) #3220353fd0d80b1
] - (SEMVER-MINOR) util: use a global symbol forutil.promisify.custom
(ExE Boss) #31672e83dcdef7e
] - (SEMVER-MINOR) worker: allow URL in Worker constructor (Antoine du HAMEL) #31664