stream: avoid unnecessary concat of a single buffer. #3300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it.
calvinmetcalf
force-pushed
the
stream-opt
branch
from
6a3e97d to
8c462af
Compare
calvinmetcalf
changed the title
|
now featuring a correctly spelled 'unnecessary' |
|
Nice catch! +1 in this change |
|
👍 |
|
LGTM! |
|
👍 |
|
LGTM so long as CI is green |
|
CI pass looks good. Two unrelated failures. |
|
🎉 |
jasnell
pushed a commit
that referenced
this pull request
Oct 14, 2015
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it. Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3300
|
Landed in 8854183 |
jasnell
pushed a commit
that referenced
this pull request
Oct 26, 2015
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it. Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3300
jasnell
pushed a commit
that referenced
this pull request
Oct 29, 2015
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it. Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3300
This was referenced Feb 20, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This was referenced May 13, 2024
This was referenced May 22, 2024
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids doing a buffer.concat on the internal buffer when that array has only a single thing in it. As pointed out in nodejs/readable-stream#162 this causes an unnecessary copy.