Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Proposal: v4.2.2 "Argon" (LTS) #3588

Closed
wants to merge 1 commit into from
Closed

Release Proposal: v4.2.2 "Argon" (LTS) #3588

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 29, 2015

Target release date is Monday, November 2nd

Notable changes

This is an LTS maintenance release that addresses a number of issues:

  • [1d0f2cbf87] - buffer: fix value check for writeUInt{B,L}E (Trevor Norris) #3500
  • [2a45b72b4a] - buffer: don't CHECK on zero-sized realloc (Ben Noordhuis) #3499
  • [a6469e901a] - deps: backport 010897c from V8 upstream (Ali Ijaz Sheikh) #3520
  • [cadee67c25] - deps: backport 8d6a228 from the v8's upstream (Fedor Indutny) #3549
  • [46c8c94055] - fs: reduced duplicate code in fs.write() (ronkorving) #2947
  • [0427cdf094] - http: fix stalled pipeline bug (Fedor Indutny) #3342
  • [2109708186] - lib: fix cluster handle leak (Rich Trott) #3510
  • [f49c7c6955] - lib: avoid REPL exit on completion error (Rich Trott) #3358
  • [8a2c4aeeaa] - repl: handle comments properly (Sakthipriyan Vairamani) #3515
  • [a04408acce] - repl: limit persistent history correctly on load (Jeremiah Senkpiel) #2356
  • [3bafe1a59b] - src: fix race condition in debug signal on exit (Ben Noordhuis) #3528
  • [fe01d0df7a] - src: fix exception message encoding on Windows (Brian White) #3288
  • [4bac5d9ddf] - stream: avoid unnecessary concat of a single buffer. (Calvin Metcalf) #3300
  • [8d78d687d5] - timers: reuse timer in setTimeout().unref() (Fedor Indutny) #3407
  • [e69c869399] - tls: TLSSocket options default isServer false (Yuval Brik) #2614

Release Candidate 1 Build for testing: https://nodejs.org/download/rc/v4.2.2-rc.1/

@jasnell
Copy link
Member Author

jasnell commented Oct 29, 2015

Note that there are no new features. As an LTS release, this contains patch, doc and test updates only. It should be a drop in replacement for v4.2.1 and everything should just work. Please notify of any regressions as soon as possible.

@jasnell jasnell mentioned this pull request Oct 29, 2015
Closed
@MylesBorins
Copy link
Contributor

@jasnell is there a good process for installing these rc's with nvm?

/cc @ljharb

@jasnell
Copy link
Member Author

jasnell commented Oct 29, 2015

Additional commits we need to look at for release:

There are additional PR's on the watch list that have not yet landed: https://github.com/nodejs/node/labels/lts-watch-v4.x

@jasnell
Copy link
Member Author

jasnell commented Oct 29, 2015

@thealphanerd ... not that I'm aware of but I don't use nvm that much

@jasnell
Copy link
Member Author

jasnell commented Oct 29, 2015

Updated with additional commits. Will do a RC2 build tomorrow.

@Fishrock123 Fishrock123 added meta Issues and PRs related to the general management of the project. lts Issues and PRs related to Long Term Support releases. labels Oct 29, 2015
@rvagg
Copy link
Member

rvagg commented Oct 30, 2015

These commits seem like candidates too, two test commits and the rest are docs. My thought behind including all the docs ones, including things like changing AUTHORS.md, and COLLABORATOR_GUIDE.md is that it'll make it much easier down the road if we ever need to update them given that they'll match master. Up for debate though of course.

  • [26e47efbca] - test: split independent tests into separate files (Rich Trott) #3548
  • [3a091d29bf] - test: add node::MakeCallback() test coverage (Ben Noordhuis) #3478
  • [753509f579] - build: rectify --link-module help text (P.S.V.R) #3379
  • [d394e9e6bb] - doc: add LTS info to COLLABORATOR_GUIDE.md (Myles Borins) #3442
  • [5d5a4c4c18] - doc: createServer's key option can be an array (Sakthipriyan Vairamani) #3123
  • [052611b0d1] - doc: add TSC meeting minutes 2015-10-21 (Rod Vagg) #3480
  • [0a0926e863] - doc: add TSC meeting minutes 2015-10-14 (Rod Vagg) #3463
  • [d381290854] - doc: more use-cases for promise events (Domenic Denicola) #3438
  • [829eb97fef] - doc: update WORKING_GROUPS.md - add missing groups (Michael Dawson) #3450
  • [cba5d2b948] - doc: add TSC meeting minutes 2015-09-30 (Rod Vagg) #3235
  • [a441aa6e1d] - doc: update WORKING_GROUPS.md to include Intl (Steven R. Loomis) #3251
  • [3ef2e4acf3] - doc: fix typos in changelog (reggi) #3291
  • [b9279aa193] - doc: remove old note, 'cluster' is marked stable (Balázs Galambosi) #3314
  • [cdfa271164] - doc: update AUTHORS list (Rod Vagg)
  • [57f99a9479] - doc: binary encoding is not deprecated (Trevor Norris) #3441

@rvagg
Copy link
Member

rvagg commented Oct 30, 2015

If we're aiming for early next week then we're pushing it a little on our new "commits should be in a stable release already" rule since v5.0.0 just went out with all of the commits included here. They'll be in the wild over the weekend but I wouldn't be upset if this release took its time.

@rvagg
Copy link
Member

rvagg commented Oct 30, 2015

Sorry for spamming this PR, but @jasnell I wanted to let you know I've added experimental --end-ref support to branch-diff so we can do the "what's already been in a release" queries, e.g.:

branch-diff v4.x master --exclude-label=meta,semver-minor,semver-major --end-ref=v5.0.0

I'll also end up adding --start-ref so that when the branches diverge more we'll be able to limit the query to specific windows.

@jasnell
Copy link
Member Author

jasnell commented Oct 30, 2015

@rvagg ... yep, which is another reason for going the v4.2.2-rc.1 route yesterday. The challenge is the timing of v5.0 release -- I'd been hoping it would have gotten out sooner ;-)

@jasnell
Copy link
Member Author

jasnell commented Oct 30, 2015

@rvagg ... I'd likely break them down this way:

Should Land:

  • [57f99a9479] - doc: binary encoding is not deprecated (Trevor Norris) #3441
  • [5d5a4c4c18] - doc: createServer's key option can be an array (Sakthipriyan Vairamani) #3123
  • [d381290854] - doc: more use-cases for promise events (Domenic Denicola) #3438
  • [26e47efbca] - test: split independent tests into separate files (Rich Trott) #3548
  • [3a091d29bf] - test: add node::MakeCallback() test coverage (Ben Noordhuis) #3478
  • [753509f579] - build: rectify --link-module help text (P.S.V.R) #3379
  • [3ef2e4acf3] - doc: fix typos in changelog (reggi) #3291
  • [b9279aa193] - doc: remove old note, 'cluster' is marked stable (Balázs Galambosi) #3314

Optional:

  • [d394e9e6bb] - doc: add LTS info to COLLABORATOR_GUIDE.md (Myles Borins) #3442
  • [052611b0d1] - doc: add TSC meeting minutes 2015-10-21 (Rod Vagg) #3480
  • [0a0926e863] - doc: add TSC meeting minutes 2015-10-14 (Rod Vagg) #3463
  • [829eb97fef] - doc: update WORKING_GROUPS.md - add missing groups (Michael Dawson) #3450
  • [cba5d2b948] - doc: add TSC meeting minutes 2015-09-30 (Rod Vagg) #3235
  • [a441aa6e1d] - doc: update WORKING_GROUPS.md to include Intl (Steven R. Loomis) #3251
  • [cdfa271164] - doc: update AUTHORS list (Rod Vagg)

@jasnell
Copy link
Member Author

jasnell commented Oct 30, 2015

@rvagg ... ok, pushed the checked items from your list above for v4.2.2. The rest I would consider entirely optional and ok to leave out for now.

@jasnell
Copy link
Member Author

jasnell commented Oct 30, 2015

@rvagg ... how about this: so we don't rush this out too quickly, let's do a RC2 build on Monday and give it another day or two of testing. We can do the actual release either later in the day Tuesday or Wednesday. That'll give at least another few days to see if there are any new regressions

@jasnell
Copy link
Member Author

jasnell commented Nov 2, 2015

RC2 build running now - https://ci.nodejs.org/job/iojs+release/248/

@rvagg
Copy link
Member

rvagg commented Nov 3, 2015

sorry for late response @jasnell but I'm +1 on all your comments above

@jasnell
Copy link
Member Author

jasnell commented Nov 3, 2015

Given that no regressions have been reported and the commits that have landed also in v5.0.0 appear to be good with no obvious new regressions there, I'll be moving ahead with the v4.2.2 release later on today. I'll kick off the build around noon pacific. /cc @nodejs/collaborators @nodejs/lts

@jasnell
Copy link
Member Author

jasnell commented Nov 3, 2015

v4.2.2 is released

@jasnell jasnell closed this Nov 3, 2015
hmalphettes added a commit to hmalphettes/docker-node that referenced this pull request Nov 4, 2015
@hmalphettes
Upgrade node-v4.2.1 to node-v4.2.2
9992908 
Reference: nodejs/node#3588
@hmalphettes hmalphettes mentioned this pull request Nov 4, 2015
Merged
hmalphettes added a commit to hmalphettes/official-images that referenced this pull request Nov 4, 2015
@hmalphettes
Update node-v4.2.1 (LTS) to node-v4.2.2
976b362 
References:
- nodejs/node#3588
- nodejs/docker-node#62
@hmalphettes hmalphettes mentioned this pull request Nov 4, 2015
Merged
pierreozoux pushed a commit to pierreozoux/official-images that referenced this pull request Jan 7, 2016
@hmalphettes @pierreozoux
Update node-v4.2.1 (LTS) to node-v4.2.2
d303bb0 
References:
- nodejs/node#3588
- nodejs/docker-node#62
@targos targos deleted the v4.2.2-proposal branch April 27, 2016 13:01
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
@hmalphettes @RichardScothern
Update node-v4.2.1 (LTS) to node-v4.2.2
b4905fb 
References:
- nodejs/node#3588
- nodejs/docker-node#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lts Issues and PRs related to Long Term Support releases. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @MylesBorins @rvagg @Fishrock123