Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: Duplex re-use Writable properties #33079

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Apr 26, 2020

Instead of reimplementing Writable properties, fetch them
from the Writable prototype.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Apr 26, 2020
@ronag ronag force-pushed the duplex-refacfor-properties branch from 5b199fa to 0877fea Compare April 26, 2020 17:44
Instead of reimplementing Writable properties, fetch them
from the Writable prototype.
@ronag ronag force-pushed the duplex-refacfor-properties branch from 0877fea to f5c7fb3 Compare April 26, 2020 17:45
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 26, 2020
@nodejs-github-bot
Copy link
Collaborator

@ronag ronag requested a review from lpinca April 26, 2020 21:56
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31017/ (:yellow_heart:)

addaleax pushed a commit that referenced this pull request Apr 29, 2020
Instead of reimplementing Writable properties, fetch them
from the Writable prototype.

PR-URL: #33079
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax
Copy link
Member

Landed in 5c91a75

@addaleax addaleax closed this Apr 29, 2020
targos pushed a commit that referenced this pull request May 4, 2020
Instead of reimplementing Writable properties, fetch them
from the Writable prototype.

PR-URL: #33079
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request May 4, 2020
@uwinkelvos
Copy link

Hey @targos!
Is there any reason why the node-12 backport of this is blocked? Would be nice if this could still land in node 12 to unblock #33390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants