Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: Duplex forward writableObjectMode #33390

Closed
wants to merge 2 commits into from
Closed

stream: Duplex forward writableObjectMode #33390

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented May 13, 2020

Duplex did not properly forward writableObjectMode.

Fixes: #33388

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label May 13, 2020
@ronag ronag requested review from BridgeAR, jasnell and lpinca May 13, 2020 19:15
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31314/

lpinca
lpinca approved these changes May 13, 2020
View reviewed changes
test/parallel/test-stream-duplex-props.js Outdated Show resolved Hide resolved
@ronag
stream: Duplex forward writableObjectMode
3326255 
Duplex did not properly forward writableObjectMode.

Fixes: nodejs#33388
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31315/

@lpinca
Copy link
Member

lpinca commented May 17, 2020

@ronag I think you accidentally pushed a spurious benchmark/streams/pipeline.js file.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31365/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31370/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31371/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31392/

@ronag
Copy link
Member Author

ronag commented May 18, 2020

Landed in 2361b5c

@ronag ronag closed this May 18, 2020
ronag added a commit that referenced this pull request May 18, 2020
@ronag
stream: forward writableObjectMode
2361b5c 
Duplex did not properly forward writableObjectMode.

Fixes: #33388

PR-URL: #33390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request May 21, 2020
@ronag @codebytere
stream: forward writableObjectMode
caa6706 
Duplex did not properly forward writableObjectMode.

Fixes: #33388

PR-URL: #33390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
@codebytere
Copy link
Member

Blocked on #33079

@uwinkelvos uwinkelvos mentioned this pull request Mar 18, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplex stream is not returning whether it is in object mode correctly
5 participants
@ronag @nodejs-github-bot @lpinca @codebytere @addaleax