Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove util from child-process test #3336

Closed
wants to merge 1 commit into from
Closed

test: remove util from child-process test #3336

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

Simple PR inspired by #3324

Util is being used in test-child-process-spawnsync-input.js for string templating.

This PR replaces that with a template string.s

Simple PR inspired by #3324

Util is being used in test-child-process-spawnsync-input.js for string templating.

This PR replaces that with a template string.s
@MylesBorins
Copy link
Contributor Author

/cc @jasnell @Trott

@brendanashworth brendanashworth added the test Issues and PRs related to the tests. label Oct 13, 2015
@jasnell
Copy link
Member

jasnell commented Oct 13, 2015

LGTM

@Trott
Copy link
Member

Trott commented Oct 13, 2015

LGTM if CI is happy

@Trott
Copy link
Member

Trott commented Oct 13, 2015

@MylesBorins MylesBorins deleted the removeUtilSpawnSync branch October 14, 2015 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants