Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: port domains regression test from v0.10 #3356

Closed
wants to merge 1 commit into from
Closed

test: port domains regression test from v0.10 #3356

wants to merge 1 commit into from

Commits on Oct 14, 2015

  1. test: port domains regression test from v0.10 

    f2a45ca contained a test for a
regression that had been introduced by the original change that
77a10ed ported. While
77a10ed did not contain that
regression, the test that f2a45ca
contained should still be in the code base to prevent any regression
from happening in the future.

Original message for the commit that contained the test:

  domains: fix stack clearing after error handled

  caeb677 introduced a regression where
  the domains stack would not be cleared after an error had been handled
  by the top-level domain.

  This change clears the domains stack regardless of the position of the
  active domain in the stack.

  PR: nodejs#9364
  PR-URL: nodejs/node-v0.x-archive#9364
  Reviewed-By: Trevor Norris <trev.norris@gmail.com>
  Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    @dohse
    dohse authored and Julien Gilli committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    8b58dfa View commit details
    Browse the repository at this point in the history