Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] doc: update tls.md #33641

Closed
wants to merge 1 commit into from
Closed

[v10.x] doc: update tls.md #33641

wants to merge 1 commit into from

Conversation

sparsh-99
Copy link

@sparsh-99 sparsh-99 commented May 29, 2020 •
edited
Loading

#33631
Added the missing single quotes in minVersion and maxVersion of api/tls doc before TLSv1.2

Version: v10.x
Platform: n/a
Subsystem: doc, tls

  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels May 29, 2020
@richardlau richardlau changed the base branch from master to v10.x-staging May 29, 2020 18:01
@sparsh-99 sparsh-99 mentioned this pull request May 29, 2020
Closed
@BridgeAR BridgeAR changed the title doc: update tls.md v10.x-staging [v10x] doc: update tls.md May 30, 2020
@sparsh-99
Copy link
Author

Hey @BridgeAR @lpinca @MrHeer @Luccasoli @rexagod , I want to know the status of this PR that why it is not merged yet? Is there any problem or something else? Please let me know.
Thank You

juanarbol
juanarbol approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for your contribution!

@juanarbol
Copy link
Member

@sparsh-99 your PR needs to pass the CI first, it seems like GitHub actions are not defined for v10.x-staging at this moment.

@juanarbol juanarbol added land-on-v10.x author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 16, 2020
@BethGriggs BethGriggs changed the title [v10x] doc: update tls.md [v10.x] doc: update tls.md Jul 14, 2020
@sparsh-99 @richardlau
Update tls.md v10.x-staging
3bd95db 
Added the missing single quotes in minVersion and maxVersion of api/tls doc before TLSv1.2
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32355/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32357/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32358/

@richardlau
Copy link
Member

Landed in 00f04e3.

@richardlau richardlau closed this Jul 15, 2020
@richardlau richardlau mentioned this pull request Jul 15, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Jul 15, 2020
@sparsh-99 @richardlau
doc: fix quotes in tls.md
00f04e3 
Added the missing single quotes in minVersion and maxVersion of api/tls
doc before TLSv1.2.

PR-URL: #33641
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@juanarbol juanarbol juanarbol approved these changes

@MrHeer MrHeer MrHeer approved these changes

@Luccasoli Luccasoli Luccasoli approved these changes

@rexagod rexagod rexagod approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sparsh-99 @juanarbol @nodejs-github-bot @richardlau @lpinca @BridgeAR @MrHeer @Luccasoli @rexagod @BethGriggs