Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.22.0 proposal #34170

Merged
merged 22 commits into from
Jul 21, 2020
Merged

v10.22.0 proposal #34170

merged 22 commits into from
Jul 21, 2020

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Jul 2, 2020

2020-07-21, Version 10.22.0 'Dubnium' (LTS), @BethGriggs prepared by @richardlau

Notable changes

  • deps:
    • upgrade npm to 6.14.6 (claudiahdz) #34246
    • upgrade openssl sources to 1.1.1g (Hassaan Pasha) #32982
  • n-api:
    • add napi_detach_arraybuffer (legendecas) #29768

Commits

  • [9915774d18] - build: log detected compilers in --verbose mode (Richard Lau) #32715
  • [145dcc2c1c] - build: move doc versions JSON file out of out/doc (Richard Lau) #32728
  • [24b927ab66] - build: allow clang 10+ in configure.py (Kamil Rytarowski) #29541
  • [97b59527c7] - deps: upgrade npm to 6.14.6 (claudiahdz) #34246
  • [84fca3c691] - deps: upgrade npm to 6.14.5 (Ruy Adorno) #33239
  • [745b329260] - deps: update archs files for OpenSSL-1.1.1g (Hassaan Pasha) #32982
  • [94702c1560] - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) #32982
  • [ef9413be1a] - deps: upgrade openssl sources to 1.1.1f (Hassaan Pasha) #32583
  • [3acc89f8f2] - deps: V8: backport cd21f71f9cb5 (Michaël Zasso) #33862
  • [89a306bca9] - deps: fix V8 compiler error with clang++-11 (Sam Roberts) #33094
  • [00f04e3b79] - doc: fix quotes in tls.md (Sparsh Garg) #33641
  • [193d1d0e84] - doc: document fs.watchFile() bigint option (cjihrig) #32128
  • [5dab101b03] - doc,n-api: mark napi_detach_arraybuffer as experimental (legendecas) #30703
  • [069b6e14a4] - http: disable headersTimeout check when set to zero (Paolo Insogna) #33307
  • [aaf2f827c6] - inspector: more conservative minimum stack size (Ben Noordhuis) #27855
  • [b744ffd586] - (SEMVER-MINOR) n-api: implement napi_is_detached_arraybuffer (Denys Otrishko) #30613
  • [961598b9be] - (SEMVER-MINOR) n-api: add napi_detach_arraybuffer (legendecas) #29768
  • [7a109febc4] - test: remove timers-blocking-callback (Jeremiah Senkpiel) #32870
  • [3dbd8cd3a9] - Revert "test: mark empty udp tests flaky on OS X" (Luigi Pinca) #32489
  • [543656928c] - test: flaky test-stdout-close-catch on freebsd (Sam Roberts) #32849
  • [74b00cca64] - tls: allow empty subject even with altNames defined (Jason Macgowan) #22906

cc @nodejs/releasers

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

krytarowski and others added 17 commits June 2, 2020 19:15
Detected on NetBSD/amd64.

Fixes: #29536

PR-URL: #29541
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Log the versions of the detected compilers when the configure script
is run with `--verbose` to help verify which compiler is being used if
multiple toolchains are installed on the system.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32715
Backport-PR-URL: #32820
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fixes: #33040

  error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to
    'bool' in initializer list [-Wc++11-narrowing]
  ParameterList result{{}, {}, context->VARARGS(), {}};

Occurs twice:
  ../../deps/v8/src/torque/ast-generator.cc:123:32:
  ../../deps/v8/src/torque/ast-generator.cc:144:32:

PR-URL: #33094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Original commit message:

    [parser] Validate destructuring assignment pattern in correct classifier

    Previously we'd first accumulate errors to the parent and validate the
    destructuring pattern in the parent. In the case of ParseArguments this
    will invalidly propagate binding pattern errors from one argument to the
    next. The reason why ParseArguments keeps track of binding pattern errors
    is because it could also be used to parse async arrow function parameters.
    If we see async(a,b) we don't yet know whether this is the head of an
    async arrow function, or a call to async with arguments a and b.

    Bug: v8:8241
    Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f
    Reviewed-on: https://chromium-review.googlesource.com/c/1296229
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56887}

Refs: v8/v8@cd21f71
Fixes: #23142

PR-URL: #33862
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
which is the musl architecture with the biggest MINSIGSTKSZ so let's
use that as a lower bound and let's quadruple it just in case.

Backport-PR-URL: #33720
PR-URL: #27855
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz
    $ mv openssl-1.1.0h openssl
    $ git add --all openssl
    $ git commit openssl

Backport-PR-URL: #32982
PR-URL: #32583
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1g.tar.gz
    $ mv openssl-1.1.1g openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: #32982
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
   $ cd deps/openssl/config
   $ make
   $ git add deps/openssl/config/archs
   $ git add deps/openssl/openssl/include/crypto/bn_conf.h
   $ git add deps/openssl/openssl/include/crypto/dso_conf.h
   $ git add deps/openssl/openssl/include/openssl/opensslconf.h
   $ git commit

PR-URL: #32982
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Behavior described in #11771
is still true even though the issue is closed.

This PR is to allow DNS and URI names, even when there is not a subject.

Refs: #11771

PR-URL: #22906
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit documents the bigint option to fs.watchFile(), which
has been supported since v10.5.0.

PR-URL: #32128
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This reverts commit 24a4f76.

PR-URL: #32489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
As ArrayBuffer#detach is an ecma spec operation
([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
it might be good to have it in N-API.

Fixes: #29674
PR-URL: #29768
Backport-PR-URL: #33061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: #29955

PR-URL: #30613
Backport-PR-URL: #33061
Fixes: #29955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
As its actual release stage.

PR-URL: #30703
Backport-PR-URL: #33061
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #33307
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v10.x labels Jul 2, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 2, 2020

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 2, 2020

@richardlau
Copy link
Member Author

rc.0 download link: https://nodejs.org/download/rc/v10.22.0-rc.0/

@codebytere
Copy link
Member

codebytere commented Jul 3, 2020

@richardlau in the release commit we want plaintext, so i think we may want to change to :

Notable changes:

deps:
  * upgrade openssl sources to 1.1.1g (Hassaan Pasha) https://github.com/nodejs/node/pull/32982
n-api:
  * add `napi_detach_arraybuffer` (legendecas) https://github.com/nodejs/node/pull/29768

(no idea why gh is highlighting the pull link, if you hit edit on this comment you'll see the correct formatting)

@richardlau
Copy link
Member Author

I'm waiting for the CI to complete for #34246 before landing it on master, but since the npm update fixes a low severity security advisory (GHSA-93f3-23rq-pjfp) I'm proposing we pull it into the v10.22.0 release as we don't have another 10.x release planned in the near future. This would be ahead of our usual policy of a change being released in current for two weeks before going into an LTS release. We're proposing releasing Node.js v10.22.0 on 21 July by which time the npm release will have been out in the wild (not in a Node.js release but for anything out there using the latest npm version) for two weeks.

Thoughts/objections? @nodejs/lts

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ruyadorno and others added 2 commits July 13, 2020 14:22
PR-URL: #33239
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #34246
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau added a commit that referenced this pull request Jul 13, 2020
Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 13, 2020

Fishrock123 and others added 3 commits July 15, 2020 10:18
If the bug this test is intented to catch is reintroduced, or if
5aac4c4 is effectively reverted, many
(50+) tests time out, rendering this test redundant and unnecessary.

in particular, the following timer tests catch an effective revert of
5aac4c4:

not ok 21 parallel/test-timers-api-refs
not ok 22 parallel/test-timers-args
not ok 23 parallel/test-timers-destroyed
not ok 25 parallel/test-timers-nested
not ok 26 parallel/test-timers-interval-throw
not ok 28 parallel/test-timers-non-integer-delay
not ok 32 parallel/test-timers-ordering
not ok 33 parallel/test-timers-refresh
not ok 34 parallel/test-timers-refresh-in-callback
not ok 35 parallel/test-timers-reset-process-domain-on-throw
not ok 40 parallel/test-timers-timeout-to-interval
not ok 41 parallel/test-timers-uncaught-exception
not ok 42 parallel/test-timers-timeout-with-non-integer
not ok 43 parallel/test-timers-unenroll-unref-interval
not ok 44 parallel/test-timers-unref
not ok 45 parallel/test-timers-unref-active
not ok 46 parallel/test-timers-unrefd-interval-still-fires
not ok 47 parallel/test-timers-unrefed-in-callback
not ok 48 parallel/test-timers-user-call
not ok 49 parallel/test-timers-zero-timeout

Refs: #21781

PR-URL: #32870
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Added the missing single quotes in minVersion and maxVersion of api/tls
doc before TLSv1.2.

PR-URL: #33641
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170
@richardlau
Copy link
Member Author

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 20, 2020

@richardlau
Copy link
Member Author

@richardlau
Copy link
Member Author

CITGM analysis

Using nodejs/node-core-utils#455 to highlight modules that failed in the CITGM run for this PR vs a CITGM run for the current v10.x:

-bash-4.2$ npx -p codebytere/node-core-utils#allow-citgm-comparison ncu-ci citgm 2421 2417
npx: installed 348 in 18.855s
--------------------------------------------------------------------------------
[1/1] Running CITGM: 2421
--------------------------------------------------------------------------------
✔  Summary data downloaded
✔  Results data downloaded
✔  Summary data downloaded
✔  Results data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/2421/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/v10.x
Commit     [0bd44b4a88b7] Working on v10.21.1
Date       2020-06-02 18:57:33 +0100
Author     Bethany.Griggs <Bethany.Griggs@uk.ibm.com>
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/2417/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/v10.22.0-proposal
Commit     [c5215d0b3da0] 2020-07-21, Version 10.22.0 'Dubnium' (LTS)
Date       2020-07-15 11:27:18 -0400
Author     Richard Lau <riclau@uk.ibm.com>
----------------------------------- Results ------------------------------------



FAILURE: 9 failures in 2417 not present in 2421


┌────────────────────────┬─────────────────────┬──────────────────┐
│        (index)         │          0          │        1         │
├────────────────────────┼─────────────────────┼──────────────────┤
│      aix71-ppc64       │ 'ember-cli-v3.19.0' │                  │
│     ubuntu1804-64      │                     │                  │
│ fedora-last-latest-x64 │ 'spawn-wrap-v2.0.0' │ 'winston-v3.3.3' │
│        osx1014         │  'fastify-v3.0.3'   │                  │
│     ubuntu1404-64      │                     │                  │
│      rhel7-s390x       │ 'uglify-js-v3.10.0' │                  │
│        osx1015         │                     │                  │
│     centos7-ppcle      │ 'ember-cli-v3.19.0' │ 'multer-v1.4.2'  │
│     ubuntu1604-64      │   'clinic-v6.0.2'   │ 'yargs-v15.4.1'  │
│       debian9-64       │                     │                  │
│   fedora-latest-x64    │                     │                  │
└────────────────────────┴─────────────────────┴──────────────────┘
-bash-4.2$

The clinic-v6.0.2, ember-cli-v3.19.0, fastify-v3.0.3, spawn-wrap-v2.0.0 and yargs-v15.4.1 failures also occurred on other platforms in the CITGM run for v10.x.

Which leaves multer-v1.4.2, uglify-js-v3.10.0 and winston-v3.3.3.
multer-v1.4.2 failures were also seen in a nobuild CITGM job with v10.21.0: https://ci.nodejs.org/job/citgm-smoker-nobuild/870/.
uglify-js-v3.10.0 and winston-v3.3.3 didn't reoccur in a CITGM rerun on the same commit (c5215d0) for this PR: https://ci.nodejs.org/job/citgm-smoker/2427

@BethGriggs BethGriggs merged commit c5215d0 into v10.x Jul 21, 2020
BethGriggs added a commit that referenced this pull request Jul 21, 2020
BethGriggs pushed a commit that referenced this pull request Jul 21, 2020
Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Jul 21, 2020
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Jul 21, 2020
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170
@devsnek devsnek deleted the v10.22.0-proposal branch August 31, 2020 14:31
@BethGriggs BethGriggs removed their assignment Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.