Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] src,doc,test: remove String::New default parameter #34357

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

kNormal has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

PR-URL: #34248
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

PR-URL: nodejs#34248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Jul 14, 2020
@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member Author

Ah, this doesn’t apply on v12.x because of our ABI compat patches … well, nothing we can do in this case I think 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants