Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] src,doc,test: remove String::New default parameter #34357

Closed
wants to merge 1 commit into from
Closed

[v12.x] src,doc,test: remove String::New default parameter #34357

wants to merge 1 commit into from

Commits on Jul 14, 2020

  1. src,doc,test: remove String::New default parameter 

    `kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

PR-URL: nodejs#34248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    1ba6cf1 View commit details
    Browse the repository at this point in the history