Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-heapdump-http2 #34415

Merged
merged 0 commits into from
Jul 19, 2020
Merged

test: fix flaky test-heapdump-http2 #34415

merged 0 commits into from
Jul 19, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 17, 2020

Replace stream.respondWithFile(__filename) with
stream.respondWithFile(process.execPath). The test file is probably
small enough on some operating systems to be sent immediately, without
waiting for the receiving side to do anything.

The fix was figured out by addaleax. (I asked before submitting this.)

Co-authored-by: Anna Henningsen anna@addaleax.net
Ref: #34389 (comment)
Fixes: #34389

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 17, 2020
@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 17, 2020
@Trott
Copy link
Member Author

Trott commented Jul 17, 2020 •
edited
Loading

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15454/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 17, 2020
@Trott
Copy link
Member Author

Trott commented Jul 19, 2020

Landed in a51436c

@Trott Trott closed this Jul 19, 2020
@Trott Trott merged commit a51436c into nodejs:master Jul 19, 2020
@Trott Trott deleted the fix-it-fix-it branch July 19, 2020 22:27
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@Trott @cjihrig
test: fix flaky test-heapdump-http2
17b2881 
Replace stream.respondWithFile(__filename) with
stream.respondWithFile(process.execPath). The test file is probably
small enough on some operating systems to be sent immediately, without
waiting for the receiving side to do anything.

The fix was figured out by addaleax.

Co-authored-by: Anna Henningsen <anna@addaleax.net>
Ref: #34389 (comment)
Fixes: #34389

PR-URL: #34415
Refs: #34389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@Trott @MylesBorins
test: fix flaky test-heapdump-http2
30da332 
Replace stream.respondWithFile(__filename) with
stream.respondWithFile(process.execPath). The test file is probably
small enough on some operating systems to be sent immediately, without
waiting for the receiving side to do anything.

The fix was figured out by addaleax.

Co-authored-by: Anna Henningsen <anna@addaleax.net>
Ref: #34389 (comment)
Fixes: #34389

PR-URL: #34415
Refs: #34389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: fix flaky test-heapdump-http2
fb71b90 
Replace stream.respondWithFile(__filename) with
stream.respondWithFile(process.execPath). The test file is probably
small enough on some operating systems to be sent immediately, without
waiting for the receiving side to do anything.

The fix was figured out by addaleax.

Co-authored-by: Anna Henningsen <anna@addaleax.net>
Ref: #34389 (comment)
Fixes: #34389

PR-URL: #34415
Refs: #34389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: fix flaky test-heapdump-http2
cc26431 
Replace stream.respondWithFile(__filename) with
stream.respondWithFile(process.execPath). The test file is probably
small enough on some operating systems to be sent immediately, without
waiting for the receiving side to do anything.

The fix was figured out by addaleax.

Co-authored-by: Anna Henningsen <anna@addaleax.net>
Ref: #34389 (comment)
Fixes: #34389

PR-URL: #34415
Refs: #34389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate unreliable test-heapdump-http2
6 participants
@Trott @jasnell @addaleax @lpinca @richardlau @nodejs-github-bot