v14.7.0 proposal #34542
Merged
v14.7.0 proposal #34542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test is flaky in CI with `common.PORT` but not flaky if a port is determined from createServer() first. PR-URL: #34330 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Prior to this commit, API docs would be highlighted after the page loaded using `highlightjs`. This commit still uses `highlightjs`, but runs the generation during the compilation of the documentation, making it so no script needs to load on the client. This results in a faster load, as well as allowing the pages to fully functional even when JavaScript is turned off. PR-URL: #34148 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34316 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #34339 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callback Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #34352 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Use `common.hasIPv6` instead of an OS check for more reliable operation. PR-URL: #34359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Zone IDs on Linux are network interface names. The regex we use to determine valid IPs does not allow for non-alphanumeric characters in the zone ID suffix. Some machines (including the RHEL Linux/s390x machines from Marist) have zone IDs with a '.' character in them which the regex in net.isIP rejects. This changes the regex. Ref: #14500 Signed-off-by: Stewart Addison <sxa@uk.ibm.com> PR-URL: #34364 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
common.localhostIPv6 is almost entirely unused and is unnecessary. Remove it. PR-URL: #34373 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Switch to tmpDir rather than fixtures for file writing. PR-URL: #34376 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sure, I'm advocating for permitting second-person pronouns in a current PR, but the use in errors.md is superfluous and weakens the sentence. Remove it. PR-URL: #34390 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The role helps triaging issue backlogs effectively Fixes: #34054 Refs: nodejs/TSC#891 PR-URL: #34295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #34325 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Refs: nodejs/node-v0.x-archive#6900 Refs: nodejs/node-v0.x-archive#6889 PR-URL: #34323 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #34329 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
In one place, the fs docs use `previousStat` for an argument that is identified as `previous` everywhere else. Use `previous` for consistency. PR-URL: #34405 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Replace stream.respondWithFile(__filename) with stream.respondWithFile(process.execPath). The test file is probably small enough on some operating systems to be sent immediately, without waiting for the receiving side to do anything. The fix was figured out by addaleax. Co-authored-by: Anna Henningsen <anna@addaleax.net> Ref: #34389 (comment) Fixes: #34389 PR-URL: #34415 Refs: #34389 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add Richard Lau and his Release key. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #34397 Refs: nodejs/Release#585 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33674 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Add a flag that allows for the setting of a directory where all diagnostic output will be written to. e.g. --redirect-warnings Refs: #33010 (comment) PR-URL: #33584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #33718 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34419 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34419 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Remove the "Current" label for Node.js 13 in the CHANGELOG. PR-URL: #34436 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #34424 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Update ESLint to 7.5.0 PR-URL: #34423 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Add IPv6 link local scope ID suffix to the rinfo address in those received upd6 datagrams whose source address is a link local address. Add a new test case, test-dgram-udp6-link-local-address, to verify that IPv6 UDP datagrams received from a link-local source address do contain the scope ID suffix in the rinfo address field. When a packet is received from a link-local source address, if the address does not contain the scope ID suffix, it is impossible to reply back to the sender, as the kernel is not able to determine the right network interface to send the packet through and returns with an error. Ref: #1649 PR-URL: #14500 Refs: #1649 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stewart X Addison <sxa@uk.ibm.com>
PR-URL: #34387 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
CI is green. Failures in CITGM do not seem out of the ordinary. Moving ahead with the release. |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 29, 2020
Notable changes: deps: * upgrade npm to 6.14.7 (claudiahdz) #34468 dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) #14500 doc: * add AshCripps to collaborators (AshCripps) #34494 * add HarshithaKP to collaborators (Harshitha K P) #34417 * add rexagod to collaborators (Pranshu Srivastava) #34457 * add release key for Richard Lau (Richard Lau) #34397 events: * (SEMVER-MINOR) expand NodeEventTarget functionality (Anna Henningsen) #34057 src: * (SEMVER-MINOR) allow preventing SetPromiseRejectCallback (Shelley Vohr) #34387 * (SEMVER-MINOR) allow setting a dir for all diagnostic output (AshCripps) #33584 worker: * (SEMVER-MINOR) make MessagePort inherit from EventTarget (Anna Henningsen) #34057 zlib: * switch to lazy init for zlib streams (Andrey Pechkurov) #34048 PR-URL: #34542
MylesBorins
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jul 29, 2020
This was referenced Jul 29, 2020
This was referenced Aug 6, 2020
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2020-07-29, Version 14.7.0 (Current), @MylesBorins prepared by @ruyadorno
Notable Changes
Commits
0ec9f9e8b3] - async_hooks: optimize fast-path promise hook for ALS (Andrey Pechkurov) #345121b9bfb1f3c] - build: fix test-ci-js task in Makefile (Rich Trott) #344335fe066a3f9] - build: do not run benchmark tests on 'make test' (Rich Trott) #344348f6c763c4e] - build: add benchmark tests to CI runs (Rich Trott) #34288a4806e2d12] - build: speed up source tarball creation (Richard Lau) #34508cce1f3e3a8] - build: don't run test-asan workflow on non-master pushes (Richard Lau) #3450970f23eb405] - build: remove test-tarball action for windows + osx (Myles Borins) #344403fda3d4bf3] - build: don't run Actions on non-master pushes (Shelley Vohr) #34464f7600d5ab6] - deps: upgrade npm to 6.14.7 (claudiahdz) #3446802ae6d65d4] - (SEMVER-MINOR) dgram: add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) #14500ad69aa9014] - Revert "doc: move ronkorving to emeritus" (Rich Trott) #3450717bca62428] - doc: use sentence-case for GOVERNANCE.md headers (Rich Trott) #3450337752cde43] - doc: revise onboarding-extras (Rich Trott) #34496050866ddf1] - doc: remove breaking-change-helper from onboarding-extras (Rich Trott) #344972297d74fd8] - doc: add Triagers section to table of contents in GOVERNANCE.md (Rich Trott) #3450499a648738c] - doc: onboarding process extras (Gireesh Punathil) #34455bbc7eeadd9] - doc: mention triage in GOVERNANCE.md (Gireesh Punathil) #3442692c57b284b] - doc: move thefourtheye to emeritus (Rich Trott) #34471657f2d78ee] - doc: move ronkorving to emeritus (Rich Trott) #34471455dd9cc76] - doc: match link text in index to doc headline (Rich Trott) #34449f4a63f3d9a] - doc: add AshCripps to collaborators (AshCripps) #344947d058a4c01] - doc: add author-ready label ref to onboarding doc (Ruy Adorno) #34381a3c9f75b7e] - doc: add HarshithaKP to collaborators (Harshitha K P) #344174b4eb5f130] - doc: add rexagod to collaborators (Pranshu Srivastava) #3445729ad6fb34e] - doc: add statement of purpose to documentation style guide (Rich Trott) #34424631dd21709] - doc: mark Node.js 13 as End-of-Life (Antoine du Hamel) #34436905e3d18c0] - doc: fix line length in worker_threads.md (Jucke) #34419d67a2b8d38] - doc: fix typos in n-api, tls and worker_threads (Jucke) #3441939894f8842] - doc: add release key for Richard Lau (Richard Lau) #343974a828c6c06] - doc: use correct identifier for callback argument (Rich Trott) #3440510830732f6] - doc: add changes metadata to TLS newSession event (Tobias Nießen) #3429410962c81e1] - doc: introduce a triager role (Gireesh Punathil) #3429550fd2b9de9] - doc: strengthen suggestion in errors.md (Rich Trott) #34390346c201c4e] - doc: strengthen wording about fs.access() misuse (Rich Trott) #34352c28453aff4] - doc: fix typo in assert.md (Ye-hyoung Kang) #34316f60e58b6c9] - doc,tools: syntax highlight api docs at compile-time (Francisco Ryan Tolmasky I) #341481ffa8a3dd1] - events: re-use the same isTrusted getter (Anna Henningsen) #34459c93a898028] - (SEMVER-MINOR) events: expand NodeEventTarget functionality (Anna Henningsen) #340579b91467aac] - http: don't write error to socket (Robert Nagy) #34465098b193eab] - http2: avoid unnecessary buffer resize (Denys Otrishko) #344803024927c9b] - lib: initialize instance members in class constructors (Joyee Cheung) #3298482fad58ade] - lib: simplify assignment (sapics) #33718e1199af50a] - module: self referential modules in repl or-r(Daniele Belardi) #32261e7c64af404] - n-api: run all finalizers via SetImmediate() (Gabriel Schulhof) #34386668632d531] - net: allow wider regex in interface name (Stewart X Addison) #34364c05b63d8b2] - src: skip weak references for memory tracking (Anna Henningsen) #34469b12211eeca] - src: prefer internal fields in ModuleWrap (Anna Henningsen) #34470cbe6385880] - src: remove unused variable in node_file.cc (sapics) #34317d6ee1fd0c2] - src: do not crash if ToggleAsyncHook fails during termination (Anna Henningsen) #34362bd9ab00acd] - (SEMVER-MINOR) src: allow preventing SetPromiseRejectCallback (Shelley Vohr) #343875c943588bc] - (SEMVER-MINOR) src: allow setting a dir for all diagnostic output (AshCripps) #335849d40af54a6] - src: avoid strcmp in SecureContext::Init (Tobias Nießen) #34329aef41e5b52] - src: refactor CertCbDone to avoid goto statement (Tobias Nießen) #343253d4f608e42] - stream: rename opts to options (rickyes) #3433975de505079] - test: add ref comment to test-regress-GH-814_2 (Rich Trott) #34516cdc460e83d] - test: add ref comment to test-regress-doc: Close code span correctly #814 (Rich Trott) #34516cc279db29f] - test: remove superfluous check in pummel/test-timers (Rich Trott) #344883f11ba1c69] - test: fix test-heapdump-zlib (Andrey Pechkurov) #3449981eaaa27d5] - test: remove duplicate checks in pummel/test-timers (Rich Trott) #344731a9138d679] - test: delete invalid test (Anna Henningsen) #344454e2f5fa907] - test: fixup worker + source map test (Anna Henningsen) #34446cd35d00518] - test: force resigning of app (Colin Ihrig) #34331eecb92c9da] - test: fix flaky test-watch-file (Rich Trott) #3442030da332314] - test: fix flaky test-heapdump-http2 (Rich Trott) #3441577542a4a7a] - test: do not write to fixtures dir in test-watch-file (Rich Trott) #34376699da05b29] - test: remove common.localhostIPv6 (Rich Trott) #34373ec1393db63] - test: fix test-net-pingpong pummel test for non-IPv6 hosts (Rich Trott) #343598ca80427db] - test: fix flaky test-net-connect-econnrefused (Rich Trott) #34330e9c7722ea4] - tls: remove setMaxSendFragment guards (Tobias Nießen) #34323f4d61c7ce9] - tools: update ESLint to 7.5.0 (Colin Ihrig) #3442374da2c44ca] - util: improve getStringWidth performance (Ruben Bridgewater) #33674c9b652f13f] - vm: add tests for function declarations using [[DefineOwnProperty]] (ExE Boss) #34032d10fc35447] - (SEMVER-MINOR) worker: make MessagePort inherit from EventTarget (Anna Henningsen) #34057252f37630a] - zlib: switch to lazy init for zlib streams (Andrey Pechkurov) #34048