build: speed up source tarball creation #34508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
addaleax
reviewed
Jul 24, 2020
addaleax
approved these changes
Jul 24, 2020
|
|
richardlau
added
the
author ready
targos
approved these changes
Jul 25, 2020
himself65
approved these changes
Jul 25, 2020
Avoid building the node binary when building the source tarball. We need a node binary to build the docs, but it doesn't have to be one we build from scratch and can reuse any available node binary. Skip building the xz compressed tarball in the build-tarball workflow as we only use the gzip compressed tarball in the subsequent build jobs. PR-URL: nodejs#34508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
|
Landed in 3e6b05e. |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
Avoid building the node binary when building the source tarball. We need a node binary to build the docs, but it doesn't have to be one we build from scratch and can reuse any available node binary. Skip building the xz compressed tarball in the build-tarball workflow as we only use the gzip compressed tarball in the subsequent build jobs. PR-URL: #34508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid building the node binary when building the source tarball. We
need a node binary to build the docs, but it doesn't have to be one
we build from scratch and can reuse any available node binary.
Skip building the xz compressed tarball in the build-tarball workflow
as we only use the gzip compressed tarball in the subsequent build
jobs.
This significantly cuts the time for the "build-tarball" job from the
"Build from tarball" workflow from ~50mins to ~2mins.
Our release CI shouldn't be affected as the job the builds the source
tarball builds the binary tarball first so will always have a built
nodebinary to run.
Here's a test build on the release CI: https://ci-release.nodejs.org/job/iojs+release/6206/
Download: https://nodejs.org/download/test/v15.0.0-test20200724221167a148/
cc @nodejs/build-files
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes