Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove duplicate checks in pummel/test-timers #34473

Merged
merged 0 commits into from
Jul 24, 2020
Merged

test: remove duplicate checks in pummel/test-timers #34473

merged 0 commits into from
Jul 24, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 22, 2020

Remove checks in pummel/test-timers that are already checked in
parallel/test-timers-clear-null-does-not-throw-error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 22, 2020
MrHeer
MrHeer approved these changes Jul 22, 2020
View reviewed changes
Copy link

@MrHeer MrHeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Jul 22, 2020

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15529/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 22, 2020
@Trott
Copy link
Member Author

Trott commented Jul 24, 2020

Landed in 986ae1e

@Trott Trott closed this Jul 24, 2020
@Trott Trott merged commit 986ae1e into nodejs:master Jul 24, 2020
@Trott Trott deleted the remove-duplicate branch July 24, 2020 04:20
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@Trott @MylesBorins
test: remove duplicate checks in pummel/test-timers
81eaaa2 
Remove checks in pummel/test-timers that are already checked in
parallel/test-timers-clear-null-does-not-throw-error.

PR-URL: #34473
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: remove duplicate checks in pummel/test-timers
d34a7f8 
Remove checks in pummel/test-timers that are already checked in
parallel/test-timers-clear-null-does-not-throw-error.

PR-URL: #34473
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: remove duplicate checks in pummel/test-timers
72e0df3 
Remove checks in pummel/test-timers that are already checked in
parallel/test-timers-clear-null-does-not-throw-error.

PR-URL: #34473
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHeer MrHeer MrHeer approved these changes

@juanarbol juanarbol juanarbol approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jasnell @juanarbol @MrHeer @nodejs-github-bot