Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move ronkorving and thefourtheye to emeritus #34471

Merged
merged 0 commits into from
Jul 24, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 22, 2020

Moving a couple collaborators who seem relatively inactive to emeriti. /ping @ronkorving @thefourtheye If you'd prefer to remain on the active list, just leave a comment. (It can just be the word "stay" if you want. No need for any justifications or anything like that!) Otherwise, we'll land this in 48 hours. (And even then, you can always be moved back if you become active again.) Thanks for all your great work over the years!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 22, 2020
@Trott
Copy link
Member Author

Trott commented Jul 23, 2020

@nodejs/tsc This will need some reviews/approval.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 23, 2020
@Trott
Copy link
Member Author

Trott commented Jul 24, 2020

Landed in 090ad7d...1ed90e2

Trott added a commit that referenced this pull request Jul 24, 2020
PR-URL: #34471
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@Trott Trott closed this Jul 24, 2020
@Trott Trott merged commit 1ed90e2 into nodejs:master Jul 24, 2020
@Trott Trott deleted the ron-emeritus branch July 24, 2020 00:53
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
PR-URL: #34471
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
PR-URL: #34471
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34471
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34471
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34471
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34471
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants