Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: reduce repetitiveness on Consensus Seeking #34702

Closed
wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Rearrange Consensus Seeking section to reduce repetitiveness.

Ref: nodejs#34639 (comment)
Ref: nodejs#34639 (comment)
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 10, 2020
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect to me!

@mmarchini
Copy link
Contributor Author

Landed in 2f27f11

@mmarchini mmarchini closed this Aug 12, 2020
mmarchini added a commit that referenced this pull request Aug 12, 2020
Rearrange Consensus Seeking section to reduce repetitiveness.

Ref: #34639 (comment)
Ref: #34639 (comment)

PR-URL: #34702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
Rearrange Consensus Seeking section to reduce repetitiveness.

Ref: #34639 (comment)
Ref: #34639 (comment)

PR-URL: #34702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
Rearrange Consensus Seeking section to reduce repetitiveness.

Ref: #34639 (comment)
Ref: #34639 (comment)

PR-URL: #34702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Rearrange Consensus Seeking section to reduce repetitiveness.

Ref: #34639 (comment)
Ref: #34639 (comment)

PR-URL: #34702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Rearrange Consensus Seeking section to reduce repetitiveness.

Ref: #34639 (comment)
Ref: #34639 (comment)

PR-URL: #34702
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants