Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit (general) collaborator guide #34712

Merged
merged 0 commits into from
Aug 12, 2020
Merged

doc: edit (general) collaborator guide #34712

merged 0 commits into from
Aug 12, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 10, 2020

Use consistent capitalization in Consensus Seeking section, replace some
should usage with imperative, etc.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 10, 2020
Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will probably have a merge conflict with #34702.

@Trott
Copy link
Member Author

Trott commented Aug 12, 2020

LGTM. This will probably have a merge conflict with #34702.

Indeed. Rebased and force-pushed to resolve conflicts.

@Trott Trott closed this Aug 12, 2020
@Trott Trott merged commit 5f65f47 into nodejs:master Aug 12, 2020
@Trott
Copy link
Member Author

Trott commented Aug 12, 2020

Landed in 5f65f47

@Trott Trott deleted the cg-edits branch August 12, 2020 17:51
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
Use consistent capitalization in Consensus Seeking section, replace some
_should_ usage with imperative, etc.

PR-URL: #34712
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
Use consistent capitalization in Consensus Seeking section, replace some
_should_ usage with imperative, etc.

PR-URL: #34712
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Use consistent capitalization in Consensus Seeking section, replace some
_should_ usage with imperative, etc.

PR-URL: #34712
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Use consistent capitalization in Consensus Seeking section, replace some
_should_ usage with imperative, etc.

PR-URL: #34712
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants