Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make minor edits for consistency #35377

Closed
wants to merge 1 commit into from
Closed

doc: make minor edits for consistency #35377

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 27, 2020

  • We use noop and no-op in different docs. Use no-op everywhere.
  • When referring to functions, add () to indicate that.
  • Remove backticks from non-code destroyed.
Checklist

@Trott
doc: make minor edits for consistency
9c957ff 
* We use _noop_ and _no-op_ in different docs. Use _no-op_ everywhere.
* When referring to functions, add _()_ to indicate that.
* Remove backticks from non-code _destroyed_.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 27, 2020
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2020
@github-actions
Copy link
Contributor

Landed in 606df7c

@github-actions github-actions bot closed this Sep 29, 2020
nodejs-github-bot pushed a commit that referenced this pull request Sep 29, 2020
@Trott @nodejs-github-bot
doc: make minor edits for consistency
606df7c 
* We use _noop_ and _no-op_ in different docs. Use _no-op_ everywhere.
* When referring to functions, add _()_ to indicate that.
* Remove backticks from non-code _destroyed_.

PR-URL: #35377
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@Trott @danielleadams
doc: make minor edits for consistency
af360ac 
* We use _noop_ and _no-op_ in different docs. Use _no-op_ everywhere.
* When referring to functions, add _()_ to indicate that.
* Remove backticks from non-code _destroyed_.

PR-URL: #35377
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: make minor edits for consistency
bbcdad2 
* We use _noop_ and _no-op_ in different docs. Use _no-op_ everywhere.
* When referring to functions, add _()_ to indicate that.
* Remove backticks from non-code _destroyed_.

PR-URL: nodejs#35377
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott deleted the no-op-destroyed-etc branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @lpinca @targos @BridgeAR @addaleax @nodejs-github-bot