V14.13.1 proposal #35525
Merged
V14.13.1 proposal #35525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We use _noop_ and _no-op_ in different docs. Use _no-op_ everywhere. * When referring to functions, add _()_ to indicate that. * Remove backticks from non-code _destroyed_. PR-URL: #35377 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #35387 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #35379 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34930 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
GitHub Codespaces installs a copy of Python 3.8 in the repository. PR-URL: #35389 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #35373 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #34688 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
The changelog format used in gyp-next does not comply to the rules. PR-URL: #35423 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Adds support for using a section ordering file with the gold linker. This makes it possible to reorder functions in a build to optimize for a specific workload. `hfsort` is a tool that can be used to generate such a file from perf- recorded last branch record (LBR) data by running Node.js as `node --perf-basic-prof`. Refs: https://github.com/facebook/hhvm/tree/9966d482c19c6120c621c6f3896525fb19fb3842/hphp/tools/hfsort Refs: https://software.intel.com/content/www/us/en/develop/articles/runtime-optimization-blueprint-IA-optimization-with-last-branch-record.html Refs: #16891 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #35272 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #35426 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This helps catch broken links as part of the test suite. This also improves the user experience when browsing the markdown files. PR-URL: #35191 Fixes: #35189 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Add Symbol.toStringTag property to console object to follow WPT changes Update WPT status of console and the repl test case Refs: web-platform-tests/wpt#24717 PR-URL: #35399 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #35358 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Minimal CSS and markup changes to implement special rendering for `<kbd>` elements. PR-URL: #35400 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
This provides a number of minor style adjustments and small corrections to esm.md text. Co-authored-by: Guy Bedford <guybedford@gmail.com> PR-URL: #35414 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
The new behavior of node-core-utils (which fetches the merge commit instead of fetching the patch files) requires the whole repo to be cloned, instead of just the last commit. PR-URL: #35468 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
PR-URL: #35434 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
PR-URL: #35450 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Stewart X Addison <sxa@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #35406 Fixes: #35215 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #35451 Reviewed-By: Stewart X Addison <sxa@uk.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Some minor adjustments, mostly moving things to present tense and avoiding the ambiguity of _may_. Refs: #35370 (comment) PR-URL: #35427 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Update tools/doc/type-parser.js with correct URL for the module.SourceMap class. This fixes a broken link in our documentation. PR-URL: #35446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
There is a check for this in the inner `MakeCallback()` function called by it, but since the `Get()` call here can also result in a call into JS, we should ideally check the flag before that. PR-URL: #35424 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since PR #29251 is merged into master, the implementation of `console.timeEnd` is not to print the milliseconds on the stdout but instead print a more readable time unit on the console. For example if the total time comes out to be 3456 milliseconds, it will be printed as 3.45 seconds so that it is much more readable and consistent. PR-URL: #35027 Fixes: #35011 Refs: #29251 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
These objects don’t hold any resources on the event loop, so they should be weak objects that can be garbage collected when nothing refers to them anymore. PR-URL: #35481 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This call can fail, we should not use `.ToLocalChecked()` here.
In the long run, we should use variants of `EmitExit()` and
`EmitBeforeExit()` that avoid this problem by properly propagating
empty `MaybeLocal`s.
Example failure:
21:07:17 not ok 2564 parallel/test-worker-terminate-source-map
21:07:17 ---
21:07:17 duration_ms: 0.385
21:07:17 severity: crashed
21:07:17 exitcode: -6
21:07:17 stack: |-
21:07:17 FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.
21:07:17 1: 0x1012f04a5 node::Abort() (.cold.1) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
21:07:17 2: 0x1000b52d9 node::Abort() [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
21:07:17 3: 0x1000b543f node::OnFatalError(char const*, char const*) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
21:07:17 4: 0x1001ffd70 v8::V8::ToLocalEmpty() [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
21:07:17 5: 0x1000079b8 node::EmitBeforeExit(node::Environment*) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
21:07:17 6: 0x100156fea node::worker::Worker::Run() [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
21:07:17 7: 0x10015a4d2 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
21:07:17 8: 0x7fff72fe7109 _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
21:07:17 9: 0x7fff72fe2b8b thread_start [/usr/lib/system/libsystem_pthread.dylib]
21:07:17 ...
PR-URL: #35484
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams
force-pushed
the
v14.13.1-proposal
branch
from
3906071
to
7c5f319
Compare
|
Should #35171 be semver-minor? (It's fine with me if the answer is "no", but it does seem a little surprising that it would be semver-patch.) |
I don't think we have a written policy for graduating an API from experimental (we do for new modules, but I can't see one for an individual API). This particular case doesn't actually change the API or change the printing of any warning messages so it is technically patch. In any case it's definitely notable. |
|
There were a bunch of CITGM failures on windows - https://ci.nodejs.org/job/citgm-smoker/2500/nodes=win-vs2017/testReport/ Rerunning against v14.13.0 to see if they were introduced in this proposal - https://ci.nodejs.org/job/citgm-smoker/2505/ |
See https://github.com/nodejs/Release/blob/master/doc/meetings/2020-09-24.md#qa-other. We previously weren't aware of CITGM results on Windows as CITGM was broken (now fixed). |
I recall, having PR'd the minutes. But I still think it is worth running a baseline on windows against v14.13.0 to help determine whether any of the failures are specific to v14.13.1. |
|
CI: ✅ |
BethGriggs
approved these changes
Oct 7, 2020
danielleadams
pushed a commit
to danielleadams/nodejs.org
that referenced
this pull request
Oct 7, 2020
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 7, 2020
2 tasks
Trott
pushed a commit
to aduh95/node
that referenced
this pull request
Oct 24, 2020
Refs: nodejs#35525 PR-URL: nodejs#35782 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Notable changes: * fs: * remove experimental from rmdir recursive (Benjamin Coe) [nodejs#35171](nodejs#35171) PR-URL: nodejs#35525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2020-10-07, Version 14.13.1 (Current), @BethGriggs prepared by @danielleadams
Notable Changes
Commits
f36476d9d6] - build: fix CQ after latest ncu release (Mary Marchini) #354687dc6b2fac7] - build: add support for section ordering (Gabriel Schulhof) #3527205e08bdf13] - console: add Symbol.toStringTag property (Leko) #35399a01154e3fd] - crypto: fix KeyObject garbage collection (Anna Henningsen) #354811f15e34dc8] - crypto: set env values in KeyObject Deserialize method (ThakurKarthik) #3541685062b3aad] - deps: update llhttp to 2.1.3 (Fedor Indutny) #35435a995dd7a89] - doc: revise introductory child_process text (Rich Trott) #353446585b161ba] - doc: improve eventLoopUtilization documentation (Andrey Pechkurov) #35479f08577c4a6] - doc: update AUTHORS list (Anna Henningsen) #3528091ef862365] - doc: mention adding YAML for APIs in PR contributing guide (Denys Otrishko) #35459885840b543] - doc: adopt MDN style for kbd elements (Rich Trott) #354601313c8c33a] - doc: update sxa's email address to Red Hat from IBM (Stewart X Addison) #354423f95440334] - doc: fix conditional exports flag removal version (Antoine du Hamel) #35428e40876a5e5] - doc: specify how to detect EOF (Luigi Pinca) #35445541ce17386] - doc: add entry to console.timeEnd() changes array (Luigi Pinca) #3544138a5715c1a] - doc: avoid using deprecated connection property (Luigi Pinca) #35439862b75d35e] - doc: added details around console.timeEnd changes (Yash Ladha) #350274dbb3a91fe] - doc: copyedit packages.md (Rich Trott) #35427368a3ae415] - doc: update contact information for @BethGriggs (Beth Griggs) #35451a11ddee8b9] - doc: update contact information for richardlau (Richard Lau) #3545035b62ef0a7] - doc: importable node protocol URLs (Bradley Meck) #3543495c62a1dca] - doc: copyedit esm.md (Rich Trott) #3541486f2f83a2f] - doc: implement fancier rendering for keys (Rich Trott) #35400d6427886b8] - doc: unhide resolver spec (Guy Bedford) #353585a730b5def] - doc: sort md references in ASCII order (Antoine du Hamel) #35191ce789f1ca4] - doc: use .md extension for internal links (Antoine du Hamel) #3519179e3e5008d] - doc: update example ICU URL (Daijiro Wachi) #35373998b24ef17] - doc: align to function signature (anlex N) #34930af360ace37] - doc: make minor edits for consistency (Rich Trott) #3537753e27b3f67] - doc,esm: add history support info (Antoine du Hamel) #3539591b820e939] - esm: use "node:" namespace for builtins (Guy Bedford) #35387541be526c3] - fs: do not throw exception after creating FSReqCallback (Anna Henningsen) #35487f29451dece] - fs: simplify realpathSync (himself65) #35413fcbdb0686d] - fs: remove experimental from rmdir recursive (Benjamin Coe) #35171e4a4f81d19] - fs: use Promise.resolve from primordials (Michaël Zasso) #353798e3a81eed9] - http2,tls: store WriteWrap using BaseObjectPtr (Anna Henningsen) #3548862ddc77a5b] - meta: add nodejs/streams to CODEOWNERS (Matteo Collina) #3541123022066ec] - meta: add startup team in CODEOWNERS (Joyee Cheung) #354060ac5fa703e] - module: update to cjs-module-lexer@0.4.0 (Guy Bedford) #355015c879a97e6] - module: fix builtin reexport tracing (Guy Bedford) #35500f23a0e250c] - module: refine module type mismatch error cases (Guy Bedford) #354263f62f997a2] - src: more idiomatic error pattern in node_wasi (James M Snell) #35493392c8815fe] - src: use env->ThrowUVException in pipe_wrap (James M Snell) #35493e09f7f023a] - src: limit GetProcessTitle() result to 1MB (Anna Henningsen) #35492fbb9dd9ac9] - src: fix aliased buffer import warning in env.h (Yash Ladha) #354367bbf8ee256] - src: remove invalid ToLocalChecked in EmitBeforeExit (Anna Henningsen) #354845a85d4f2c6] - src: make MakeCallback() check can_call_into_js before getting method (Anna Henningsen) #354244aed176b68] - src: document required else block at src/node_platform.cc (Juan José Arboleda) #34688552ebafd06] - test: update wpt tests for encoding (Daijiro Wachi) #3533027cd99b217] - test: improve test coverage for eventtarget (Juan José Arboleda) #337335790c40c32] - tools: add missing uv_setup_argv() calls (Anna Henningsen) #35491f499302ac0] - tools: fix typo in error message (Antoine du Hamel) #354175f1d792a09] - tools: update gyp to v0.5.0 (Ujjwal Sharma) #32698ad8fce6e61] - tools: update gyp to v0.4.0 (Ujjwal Sharma) #326983e75907dea] - tools: update gyp-next to v0.3.0 (Ujjwal Sharma) #326987361a3fd1a] - tools: update gyp-next to v0.2.1 (Ujjwal Sharma) #32698190d46bdde] - tools: update gyp to 0.2.0 (Ujjwal Sharma) #32698166f14ac98] - tools: check links in api docs (Antoine du Hamel) #35191a4e5a3af85] - tools: exclude gyp from markdown link checker (Michaël Zasso) #354234d29fb56f2] - tools: add pythonenv to .gitignore (Michaël Zasso) #353896e9e5c3381] - tools,doc: fix broken link in module.html (Rich Trott) #35446