Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add nodejs/streams to CODEOWNERS #35411

Closed
wants to merge 1 commit into from
Closed

meta: add nodejs/streams to CODEOWNERS #35411

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Sep 29, 2020 •
edited
Loading

Add @nodejs/streams to CODEOWNERS

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 29, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 29, 2020
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33367/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2020

Landed in 492e260

@github-actions github-actions bot closed this Oct 4, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 4, 2020
@mcollina @nodejs-github-bot
meta: add nodejs/streams to CODEOWNERS
492e260 
PR-URL: #35411
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@mcollina @danielleadams
meta: add nodejs/streams to CODEOWNERS
62ddc77 
PR-URL: #35411
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@mcollina @joesepi
meta: add nodejs/streams to CODEOWNERS
1dc5f45 
PR-URL: nodejs#35411
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell Awaiting requested review from jasnell

@mmarchini mmarchini Awaiting requested review from mmarchini

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mcollina @nodejs-github-bot @Trott @lpinca @gengjiawen @richardlau @addaleax