Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: update to cjs-module-lexer@0.4.0 #35501

Closed
wants to merge 2 commits into from
Closed

module: update to cjs-module-lexer@0.4.0 #35501

wants to merge 2 commits into from

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Oct 4, 2020 •
edited
Loading

This updates to cjs-module-lexer@0.4.0 containing the following two improvements:

@nodejs/modules-active-members

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

targos
targos approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with an update of the link in doc/api/esm.md

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33383/

MylesBorins
MylesBorins approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Would good to have this land tomorrow so it can go out in 14 to get picked up in 12

@MylesBorins
Copy link
Contributor

fast track?

@MylesBorins MylesBorins added esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 5, 2020
@MylesBorins MylesBorins mentioned this pull request Oct 5, 2020
Closed
4 tasks
@guybedford
Copy link
Contributor Author

Happy to fast track, but there isn't too much of a rush on this since it is mostly edge cases and perf so a patch would be fine too. Still nice to get it in though.

@guybedford
Copy link
Contributor Author

@Trott would you be ok with the fast track here as well?

@MylesBorins
Copy link
Contributor

Landed in db4b0ec

@MylesBorins MylesBorins closed this Oct 5, 2020
MylesBorins pushed a commit that referenced this pull request Oct 5, 2020
@guybedford @MylesBorins
module: update to cjs-module-lexer@0.4.0
db4b0ec 
PR-URL: #35501
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@guybedford @danielleadams
module: update to cjs-module-lexer@0.4.0
0ac5fa7 
PR-URL: #35501
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@KilianKilmister KilianKilmister mentioned this pull request Oct 11, 2020
Open
4 tasks
@guybedford guybedford mentioned this pull request Oct 22, 2020
Closed
7 tasks
aduh95 pushed a commit to aduh95/node that referenced this pull request Oct 23, 2020
@guybedford @aduh95
module: update to cjs-module-lexer@0.4.0
57b6119 
PR-URL: nodejs#35501
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 23, 2020
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@guybedford @MylesBorins
module: update to cjs-module-lexer@0.4.0
cc3313d 
Backport-PR-URL: #35757
PR-URL: #35501
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@guybedford @MylesBorins
module: update to cjs-module-lexer@0.4.0
a18d0df 
Backport-PR-URL: #35757
PR-URL: #35501
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@guybedford @joesepi
module: update to cjs-module-lexer@0.4.0
50e1e56 
PR-URL: nodejs#35501
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shisama shisama shisama approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

@GeoffreyBooth GeoffreyBooth Awaiting requested review from GeoffreyBooth

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@guybedford @nodejs-github-bot @MylesBorins @jasnell @Trott @targos @shisama @aduh95