-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: copyedit esm.md #35414
Merged
Merged
doc: copyedit esm.md #35414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
esm
Issues and PRs related to the ECMAScript Modules implementation.
labels
Sep 29, 2020
Review requested:
|
addaleax
approved these changes
Sep 29, 2020
benjamingr
approved these changes
Sep 29, 2020
guybedford
approved these changes
Sep 30, 2020
DerekNonGeneric
approved these changes
Sep 30, 2020
GeoffreyBooth
approved these changes
Sep 30, 2020
This provides a number of minor style adjustments and small corrections to esm.md text. Co-authored-by: Guy Bedford <guybedford@gmail.com> PR-URL: nodejs#35414 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Landed in fa73561 |
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
This provides a number of minor style adjustments and small corrections to esm.md text. Co-authored-by: Guy Bedford <guybedford@gmail.com> PR-URL: #35414 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
This provides a number of minor style adjustments and small corrections to esm.md text. Co-authored-by: Guy Bedford <guybedford@gmail.com> PR-URL: #35414 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
This provides a number of minor style adjustments and small corrections to esm.md text. Co-authored-by: Guy Bedford <guybedford@gmail.com> PR-URL: #35414 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
This provides a number of minor style adjustments and small corrections to esm.md text. Co-authored-by: Guy Bedford <guybedford@gmail.com> PR-URL: nodejs#35414 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a number of minor style adjustments and small corrections
to esm.md text.
Checklist