-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc,esm: add history support info #35395
Conversation
Review requested:
|
Another important one is |
That's correct: Lines 856 to 875 in 6fc3b0d
|
Now that #35249 has landed, I think it makes sense to include it in this table as it certainly impact the way users are going to interact with CJS from ESM. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want this to be such a more comprehensive history of the major milestones, and we are doing REPLACEME's as well, then I would suggest also including these key milestones too:
- "imports" field
- conditional exports
- "exports" patterns
- package own name resolution
That doesn't impact the way one writes an ES module, this impacts package authors I'd say.
Not sure about these ones, they are not ESM-specific right? If so, that's probably more for package authors as well. Let me add a similar support table at the top of |
That sounds like a good separation yes. Perhaps we just have "type" mentioned on both as well. |
This comment has been minimized.
This comment has been minimized.
Documents which versions of Node.js support which ESM-feature. PR-URL: nodejs#35395 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in a556484 |
Documents which versions of Node.js support which ESM-feature. PR-URL: #35395 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Documents which versions of Node.js support which ESM-feature. PR-URL: nodejs#35395 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Documents which versions of Node.js support which ESM-feature. PR-URL: nodejs#35395 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Documents which versions of Node.js support which ESM-feature. This is intended to help library authors determine the minimal Node.js version that supports the features they are using.
I've tried to come up with an exhaustive list of ESM-only features that may impact the way one can write modules:
.js
ES modulesAm I missing something?
Refs: #35370 (comment)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passescc @guybedford