-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: implement fancier rendering for keys #35400
Conversation
@nodejs/website What do people think of this? @devsnek suggested it in another PR, and I kind of like it, but also like the simplicity of simply bolding the key name and leaving it at that (the "before" state above). On the other hand, we could go even further and copy the CSS for the |
Also this https://snek.dev/keyboard |
I like the MDN style personally, but I notice they're also wrapping the whole keystroke in an |
I generally like the MDN / GitHub style (see below). I'm generally fine with any of the proposed solutions, though. GitHub Style |
Yeah, the standard says that's optional (apparently for clarity) and that "Such precision isn't necessary". I like it semantically, but dislike it from a making-our-markdown-even-more-complex standpoint. I can go either way. |
Side thought, this could probably be "enforced" through the remark-node-preset by looking for a regex |
Would also suggest either copying MDN style or adding a subtle |
Minimal CSS and markup changes to implement special rendering for `<kbd>` elements. PR-URL: nodejs#35400 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Landed in aa3746d |
Minimal CSS and markup changes to implement special rendering for `<kbd>` elements. PR-URL: #35400 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Minimal CSS and markup changes to implement special rendering for `<kbd>` elements. PR-URL: nodejs#35400 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Minimal CSS and markup changes to implement special rendering for
<kbd>
elements.Checklist