Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.x] doc: fix Node.js 14.x changelogs #35756

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

richardlau
Copy link
Member

Remove the table headings for Node.js 13.x that were not removed in
631dd21.

Vertically align the list of releases in the 14.x changelog as they
are in the changelogs for 12.x and 10.x.


I'd like to fast track this, if possible, so that it can land with #35746.
cc @nodejs/releasers

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v14.x labels Oct 22, 2020
@richardlau richardlau mentioned this pull request Oct 22, 2020
4 tasks
@richardlau
Copy link
Member Author

Please 👍 to fast track.

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 22, 2020
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove the table headings for Node.js 13.x that were not removed in
631dd21.

Vertically align the list of releases in the 14.x changelog as they
are in the changelogs for 12.x and 10.x.

PR-URL: nodejs#35756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau merged commit 90a5d59 into nodejs:v14.x-staging Oct 22, 2020
@richardlau
Copy link
Member Author

Landed in 90a5d59.

@richardlau richardlau deleted the v14.xchangelog branch October 23, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants