Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.15.0 proposal #35746

Merged
merged 4 commits into from
Oct 27, 2020
Merged

v14.15.0 proposal #35746

merged 4 commits into from
Oct 27, 2020

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Oct 22, 2020

2020-10-27, Version 14.15.0 'Fermium' (LTS), @richardlau

Notable Changes

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

Commits

  • [5b7a08c902] - doc: add missing link in Node.js 14 Changelog (Antoine du Hamel) #35782
  • [90a5d59824] - doc: fix Node.js 14.x changelogs (Richard Lau) #35756
  • [7f788573b3] - Revert "test: mark test-webcrypto-encrypt-decrypt-aes flaky" (Myles Borins) #35666

@nodejs/releasers FYI this was generated via nodejs/node-core-utils#514, including the notable changes in the changelog and updating the test file.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This reverts commit 3d21792.

PR-URL: #35666
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v14.x labels Oct 22, 2020
richardlau added a commit that referenced this pull request Oct 22, 2020
Notable changes:

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

PR-URL: #35746
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member Author

This is the first LTS 14.x release and as such any commits should generally have been on current for two weeks as per https://github.com/nodejs/Release#lts-staging-branches. We try to keep the first LTS release light in terms of numbers of commits -- it's primarily to flip the LTS bit on and have the release declare itself as LTS. I'm proposing not having to run CITGM on this.

The first LTS release is semver-minor according to https://github.com/nodejs/node/blob/master/doc/guides/releases.md#lts-releases.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table in CHANGELOG_V14 should be split in two columns. See the one in V12 for example

CHANGELOG.md Show resolved Hide resolved
richardlau added a commit that referenced this pull request Oct 22, 2020
Notable changes:

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

PR-URL: #35746
CHANGELOG.md Outdated Show resolved Hide resolved
@richardlau
Copy link
Member Author

The table in CHANGELOG_V14 should be split in two columns. See the one in V12 for example

Fixed this in the tooling. Found an existing issue in the changelogs for 14.x: #35746 (comment)
Will rerun the tooling and update once #35756 lands.

Remove the table headings for Node.js 13.x that were not removed in
631dd21.

Vertically align the list of releases in the 14.x changelog as they
are in the changelogs for 12.x and 10.x.

PR-URL: #35756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau added a commit that referenced this pull request Oct 22, 2020
Notable changes:

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

PR-URL: #35746
@richardlau
Copy link
Member Author

The changelog changes should be good now. @targos PTAL.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

aduh95 and others added 2 commits October 26, 2020 06:19
Refs: #35525

PR-URL: #35782
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Notable changes:

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

PR-URL: #35746
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 26, 2020

richardlau added a commit to nodejs/nodejs-latest-linker that referenced this pull request Oct 26, 2020
@richardlau
Copy link
Member Author

richardlau commented Oct 27, 2020

Release build: https://ci-release.nodejs.org/job/iojs+release/6427/ (✔️)

richardlau added a commit that referenced this pull request Oct 27, 2020
@richardlau richardlau merged commit c1da528 into v14.x Oct 27, 2020
richardlau added a commit that referenced this pull request Oct 27, 2020
Notable changes:

This release marks the transition of Node.js 14.x into Long Term Support (LTS)
with the codename 'Fermium'. The 14.x release line now moves into "Active LTS"
and will remain so until October 2021. After that time, it will move into
"Maintenance" until end of life in April 2023.

PR-URL: #35746
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Oct 27, 2020
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Oct 27, 2020
richardlau added a commit to richardlau/tweet that referenced this pull request Oct 27, 2020
@richardlau richardlau deleted the v14.15.0-proposal branch October 29, 2020 11:24
@targos targos added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants