build: fix make test-npm #36369
Closed
build: fix make test-npm #36369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes running npm tests with `make test-npm`
nodejs-github-bot
added
the
build
cjihrig
approved these changes
Dec 3, 2020
richardlau
approved these changes
Dec 3, 2020
richardlau
added
the
npm
targos
approved these changes
Dec 5, 2020
Trott
approved these changes
Dec 8, 2020
ruyadorno
added
the
author ready
jasnell
approved these changes
Dec 8, 2020
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Dec 11, 2020
ruyadorno
added
request-ci
github-actions
bot
removed
the
request-ci
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 04e5418...752991d |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 14, 2020
Fixes running npm tests with `make test-npm` PR-URL: #36369 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
Fixes running npm tests with `make test-npm` PR-URL: #36369 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 16, 2021
Fixes running npm tests with `make test-npm` PR-URL: #36369 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Fixes running npm tests with `make test-npm` PR-URL: #36369 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes running npm tests with
make test-npmChecklist
make test-npmpasses