child_process: clean event listener correctly #36424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
added
child_process
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
Dec 9, 2020
Trott
approved these changes
Dec 12, 2020
Trott
reviewed
Dec 12, 2020
| options.signal.addEventListener('abort', () => { | ||
| if (!ex) { |
There was a problem hiding this comment.
Not blocking but: Unrelated style change?
There was a problem hiding this comment.
Yeah I just noticed it's different from the "common" way in other places in the event target code so I fixed my code there. Putting it in a new/different PR/commit seemed like overkill I think. I don't mind reverting it if it's an issue.
There was a problem hiding this comment.
Nah, I just wanted to make sure there was a reason beyond personal preference. The inconsistency in curly brace usage throughout the code base bugs me, and I want to make sure any changes have a justification beyond personal preference. It will at least allow us to inch towards consistency. Maybe we'll get there by about 2027.
benjamingr
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/36424 ✔ Done loading data for nodejs/node/pull/36424 ----------------------------------- PR info ------------------------------------ Title child_process: clean event listener correctly (#36424) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch benjamingr:child-process-signal-leak -> nodejs:master Labels child_process Commits 1 - child_process: clean event listener correctly Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/36424 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36424 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-09T18:28:27Z: https://ci.nodejs.org/job/node-test-pull-request/34880/ - Querying data for job/node-test-pull-request/34880/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 07 Dec 2020 10:56:45 GMT ✔ Approvals: 2 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36424#pullrequestreview-548497636 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36424#pullrequestreview-550773859 ⚠ This PR has conflicts that must be resolved -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/417460344 |
github-actions
bot
added
the
commit-queue-failed
I was working on AbortSignal for spawn and noticed there is a leak in the current code for AbortSignal support in child_process since it removes the wrong listener. I used the new signal as argument feature to make removing the listener easier and added a test.
benjamingr
force-pushed
the
child-process-signal-leak
branch
from
79e7602
to
b689c7f
Compare
benjamingr
added
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36424 ✔ Done loading data for nodejs/node/pull/36424 ----------------------------------- PR info ------------------------------------ Title child_process: clean event listener correctly (#36424) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch benjamingr:child-process-signal-leak -> nodejs:master Labels child_process Commits 1 - child_process: clean event listener correctly Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/36424 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36424 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - child_process: clean event listener correctly ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-12T14:34:53Z: https://ci.nodejs.org/job/node-test-pull-request/34880/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - child_process: clean event listener correctly - Querying data for job/node-test-pull-request/34880/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 07 Dec 2020 10:56:45 GMT ✔ Approvals: 2 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36424#pullrequestreview-548497636 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36424#pullrequestreview-550773859 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/438143838 |
|
Would be really useful if commit queue would know if I just rebased in a way that didn't actually change after review. |
benjamingr
added a commit
that referenced
this pull request
Dec 22, 2020
I was working on AbortSignal for spawn and noticed there is a leak in the current code for AbortSignal support in child_process since it removes the wrong listener. I used the new signal as argument feature to make removing the listener easier and added a test. PR-URL: #36424 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
I was working on AbortSignal for spawn and noticed there is a leak in the current code for AbortSignal support in child_process since it removes the wrong listener. I used the new signal as argument feature to make removing the listener easier and added a test. PR-URL: #36424 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
added
backport-open-v14.x
and removed
commit-queue-failed
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 24, 2021
I was working on AbortSignal for spawn and noticed there is a leak in the current code for AbortSignal support in child_process since it removes the wrong listener. I used the new signal as argument feature to make removing the listener easier and added a test. PR-URL: nodejs#36424 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 26, 2021
I was working on AbortSignal for spawn and noticed there is a leak in the current code for AbortSignal support in child_process since it removes the wrong listener. I used the new signal as argument feature to make removing the listener easier and added a test. PR-URL: nodejs#36424 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
I was working on AbortSignal for spawn and noticed there is a leak in the current code for AbortSignal support in child_process since it removes the wrong listener. I used the new signal as argument feature to make removing the listener easier and added a test. PR-URL: nodejs#36424 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2021
I was working on AbortSignal for spawn and noticed there is a leak in the current code for AbortSignal support in child_process since it removes the wrong listener. I used the new signal as argument feature to make removing the listener easier and added a test. PR-URL: #36424 Backport-PR-URL: #38386 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on AbortSignal for spawn and noticed there is a leak in
the current code for AbortSignal support in child_process since it
removes the wrong listener. I used the new signal as argument feature
to make removing the listener easier and added a test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes