Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.6.0 proposal #36889

Merged
merged 161 commits into from
Jan 15, 2021
Merged

v15.6.0 proposal #36889

merged 161 commits into from
Jan 15, 2021

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Jan 12, 2021

2021-01-14, Version 15.6.0 (Current), @danielleadams

Notable Changes

  • child_process:
    • add 'overlapped' stdio flag (Thiago Padilha) #29412
    • support AbortSignal in fork (Benjamin Gruenbaum) #36603
  • crypto:
    • implement basic secure heap support (James M Snell) #36779
    • fixup bug in keygen error handling (James M Snell) #36779
    • introduce X509Certificate API (James M Snell) #36804
    • implement randomuuid (James M Snell) #36729
  • doc:
  • http:
    • set lifo as the default scheduling strategy in Agent (Matteo Collina) #36685
  • net:
    • support abortSignal in server.listen (Nitzan Uziely) #36623
  • process:
    • add direct access to rss without iterating pages (Adrien Maret) #34291
  • v8:
    • fix native serdes constructors (ExE Boss) #36549

Commits

  • [3ca7a786c5] - benchmark: fix http2 benchmarks (Rich Trott) #36871
  • [4601886d7c] - benchmark: fix http/headers.js with test-double (Rich Trott) #36794
  • [7aedda9dcd] - benchmark: add simple https benchmark (Andrey Pechkurov) #36612
  • [822ac48272] - buffer: make FastBuffer safe to construct (Antoine du Hamel) #36587
  • [21f329532f] - build: refactor Makefile (raisinten) #36759
  • [857b98eed9] - build: fix unknown warning option (raisinten) #36629
  • [ffaa8c1735] - build: do not "exit" a script meant to be "source"d (François-Denis Gonthier) #35520
  • [9bc2cec848] - (SEMVER-MINOR) child_process: add 'overlapped' stdio flag (Thiago Padilha) #29412
  • [b98cc51be2] - child_process: reduce abort handler code duplication (Rich Trott) #36644
  • [78d4d91e54] - child_process: treat already-aborted controller as aborting (Rich Trott) #36644
  • [a8a427f646] - (SEMVER-MINOR) child_process: support AbortSignal in fork (Benjamin Gruenbaum) #36603
  • [7134d49e56] - child_process: clean event listener correctly (Benjamin Gruenbaum) #36424
  • [54bd4ab855] - cluster: fix edge cases that throw ERR_INTERNAL_ASSERTION (Ouyang Yadong) #36764
  • [0c11a17d82] - console: refactor to avoid unsafe array iteration (Antoine du Hamel) #36753
  • [53cf996270] - (SEMVER-MINOR) crypto: implement basic secure heap support (James M Snell) #36779
  • [42aca13953] - (SEMVER-MINOR) crypto: fixup bug in keygen error handling (James M Snell) #36779
  • [c4ad50e0ff] - (SEMVER-MINOR) crypto: introduce X509Certificate API (James M Snell) #36804
  • [4e4deca90d] - (SEMVER-MINOR) crypto: implement randomuuid (James M Snell) #36729
  • [1c9ec2529e] - deps: upgrade npm to 7.4.0 (Ruy Adorno) #36829
  • [ff5bd04900] - deps: update nghttp2 to 1.42.0 (Michaël Zasso) #36842
  • [578fa0fedf] - deps: V8: cherry-pick dfcdf7837e23 (Benjamin Coe) #36573
  • [05f34c6963] - doc: define "browser", "production", "development" (Guy Bedford) #36856
  • [e8bb1f7350] - doc: clarify event.isTrusted text (Rich Trott) #36827
  • [153be6c80e] - doc: fix module syncBuiltinESMExports example (Bruce A. MacNaughton) #34284
  • [3b64b38142] - doc: os.uptime() temporary bug notice (Nicholas Schamberg) #36503
  • [da49624a46] - doc: update release key for Danielle Adams (Danielle Adams) #36793
  • [2d8423da3c] - doc: clarify child_process.exec inherits cwd (ugultopu) #36809
  • [1a4d34ebd0] - doc: clarify descriptions of _writev chunks argument (James M Snell) #36822
  • [7c7180a6f7] - doc: document buffer's "Uint" aliases clearly (Michaël Zasso) #36796
  • [ff6edbc6b2] - doc: add dnlup to collaborators (Daniele Belardi) #36849
  • [835bdf0e50] - doc: improve crypto.randomUUID() text (Rich Trott) #36830
  • [d4bcb3689d] - doc: clarify subprocess.stdout/in/err/io properties (James M Snell) #36784
  • [a956fb3fdd] - doc: add dark mode (Ajay Poshak) #36313
  • [757b9664cd] - doc: revise method text in async_hooks.md (Rich Trott) #36736
  • [b4091ea59b] - doc: clarify when messageerror is emitted (James M Snell) #36780
  • [61b039365c] - doc: avoid memory leak warning in async_hooks example (James M Snell) #36783
  • [a7bb4da55e] - doc: clarify that --require only supports cjs (James M Snell) #36806
  • [c6eb2b4fec] - doc: clarify Buffer.from when using ArrayBuffer (James M Snell) #36785
  • [ad1d8fba9f] - doc: fix broken link for ChildProcess (James M Snell) #36788
  • [ef628891f7] - doc: revise exit() and run() text in async_hooks.md (Rich Trott) #36738
  • [ff39464559] - doc: add OpenSSL CVE fix to notable changes in v15.5.0 (Beth Griggs) #36798
  • [6db465a99f] - doc: clarify that N-API addons are context-aware (Alba Mendez) #36640
  • [fad07d5439] - doc: fix typo in esm documentation (Mohamed Kamagate) #36800
  • [67dd48ed05] - doc: add panva to collaborators (Filip Skokan) #36802
  • [b2c1aeb694] - doc: revise process.memoryUsage() text (Rich Trott) #36757
  • [8f672ebbd6] - doc: add YAML metadata for process.memoryUsage.rss (Gerhard Stoebich) #36781
  • [fa54f012b8] - doc: reduce abbreviations in async_hooks.md (Rich Trott) #36737
  • [56c00d7b2f] - doc: simplify pull request template (Rich Trott) #36739
  • [214dbac8ff] - doc: clarify undocumented stream properties (James M Snell) #36715
  • [242ce19346] - doc: document common warning types (James M Snell) #36713
  • [d3dc124575] - doc: update emitClose default for fs streams (Kevin Locke) #36653
  • [181bd0510f] - doc: improve ALS.enterWith and exit descriptions (Andrey Pechkurov) #36705
  • [edf8c6de5a] - doc: add note about uncloneable objects (James M Snell) #36534
  • [651e7d27b7] - doc: document http.IncomingMessage behaviour change (Dr) #36641
  • [72b0ab0739] - doc: add yashLadha to collaborator (Yash Ladha) #36666
  • [8a0cdb3b4e] - doc: alphabetize http response properties (Rich Trott) #36631
  • [ff4674b033] - doc: correct callback parameter type for createPushResponse() (Rich Trott) #36631
  • [f623d5d377] - doc: use _code name_ rather than _codename_ (Rich Trott) #36611
  • [1ed517c176] - doc: document return value of https.request (Michael Chen) #36370
  • [5645b21e23] - doc: document "http: lazy create IncomingMessage.headers" (ExE Boss) #36601
  • [3ee4cfc7d7] - doc: fix bugs in _construct() example (Maksym Baranovskyi) #36509
  • [93237c5999] - doc: remove replication of GitHub template (Rich Trott) #36590
  • [538f226f6d] - doc: remove "Related Issues" from pull request template (Rich Trott) #36590
  • [dcc93d3dce] - doc: expand openssl instructions (Michael Dawson) #36554
  • [41e278bf61] - docs: add references to punycode.md (Isaac Levy) #36761
  • [9b9b6d5fc5] - domain: make node resilient to Array prototype tempering (Antoine du Hamel) #36676
  • [f0a9c53bec] - errors: refactor to use more primordials (Antoine du Hamel) #36651
  • [c844d22b72] - errors: eliminate all overhead for hidden calls (Momtchil Momtchev) #35644
  • [3fa470a3c9] - events: refactor to use optional chaining (ZiJian Liu) #36763
  • [82393aefff] - events: refactor to use more primordials (Antoine du Hamel) #36304
  • [e3a091d9f3] - fs: refactor to avoid unsafe array iteration (Antoine du Hamel) #36699
  • [d5e1b82125] - fs: accept non-32-bit length in writeBuffer (raisinten) #36667
  • [d858c9576a] - http: remove dead code from internal/http.js (ZiJian Liu) #36630
  • [7e3ad1be32] - Revert "http: remove dead code from internal/http.js" (ZiJian Liu) #36890
  • [a9a2dd32e3] - http: don't cork noop .end() (Robert Nagy) #36633
  • [dfc962f67a] - http: add test case for req-res close ordering (Daniele Belardi) #36645
  • [cc28d2f541] - (SEMVER-MINOR) http: set lifo as the default scheduling strategy in Agent (Matteo Collina) #36685
  • [954a36947d] - http: make HEAD method to work with keep-alive (Joseph Hackman) #34231
  • [9156f430b5] - http: remove dead code from internal/http.js (ZiJian Liu) #36630
  • [5e499c490e] - http: refactor to use more primordials (Antoine du Hamel) #36194
  • [c784f15588] - Revert "http: use autoDestroy: true in incoming message" (Daniele Belardi) #36647
  • [a38ad0709c] - http2: refactor to use primordials instead of <string>.indexOf (Rohan Chougule) #36679
  • [e85fbb778d] - http2: fix typos in core.js (Pranshu Jethmalani) #36719
  • [a4d64f967a] - https: refactor to use more primordials (Antoine du Hamel) #36195
  • [1db3772c95] - lib: simplify primordials.uncurryThis (ExE Boss) #36866
  • [95219eac08] - lib: refactor to use mapping in cluster master (Yash Ladha) #36250
  • [b764269437] - lib: remove v8_prof_polyfill from eslint ignore list (Antoine du Hamel) #36537
  • [eb6b38639a] - lib: remove unused code (Brian White) #36632
  • [7fe1b5ef5a] - lib: refactor to use validateCallback (ZiJian Liu) #36609
  • [bb4f8c8732] - lib: use more primordials in shared validators (Pooja D P) #36552
  • [181bad58d3] - lib: add primordials.SafeArrayIterator (Antoine du Hamel) #36532
  • [6e338dac3c] - lib: refactor to use more primordials in internal/encoding.js (raisinten) #36480
  • [ec3e841f59] - lib: refactor to use primordials in internal/priority_queue.js (ZiJian Liu) #36560
  • [8ac2016229] - lib: add primordials.SafeStringIterator (Antoine du Hamel) #36526
  • [56af1250fe] - lib: make safe primordials safe to construct (Antoine du Hamel) #36428
  • [d20235b6cb] - lib: fix diagnostics_channel hasSubscribers error (ZiJian Liu) #36599
  • [63091f8440] - lib: refactor to use more primordials in internal/histogram.js (raisinten) #36455
  • [eca2df0909] - meta: notify slack when someone force pushes (Mary Marchini) #35131
  • [01213c71b9] - module: fix Windows folder exports deprecation warning (Guy Bedford) #36859
  • [302be57be4] - module: refactor to avoid unsafe array iteration (Antoine du Hamel) #36680
  • [24246a29d7] - net: throw ERR_OUT_OF_RANGE if blockList.addSubnet prefix is NaN (ZiJian Liu) #36732
  • [02dbcc4317] - (SEMVER-MINOR) net: support abortSignal in server.listen (Nitzan Uziely) #36623
  • [a258bc9b70] - perf_hooks: refactor to avoid unsafe array iteration (Antoine du Hamel) #36723
  • [94afc3e712] - process: passing -1 to setuid/setgid should not abort (James M Snell) #36786
  • [92af50327e] - (SEMVER-MINOR) process: add direct access to rss without iterating pages (Adrien Maret) #34291
  • [8b7336b072] - quic,timers: refactor to use validateAbortSignal (ZiJian Liu) #36604
  • [b17130a55a] - readline: fix behaviour of Interface plugged to a non-terminal output (Antoine du Hamel) #36774
  • [d70824f567] - src: fix typo in crypto_aes.cc (Ikko Ashimine) #36717
  • [8b43388903] - src: reduce duplicated boilerplate with new env utility fn (James M Snell) #36536
  • [a53997e6c0] - src: fix leading backslash bug in URL (raisinten) #36613
  • [abae61e230] - stream: finished waits for 'close' on OutgoingMessage (Robert Nagy) #36648
  • [4c819d65f9] - stream: fix .end() error propagation (Robert Nagy) #36817
  • [cb0b53edb1] - stream: lazy read ReadStream (Momtchil Momtchev) #36823
  • [b996e3b4b5] - stream: do not use _stream_* anymore (Matteo Collina) #36684
  • [190ddced46] - stream: only use legacy close listeners if not willEmitClose (Robert Nagy) #36649
  • [1fc30a84ac] - stream,zlib: do not use _stream_* anymore (Matteo Collina) #36618
  • [d2b9e7cb01] - string_decoder: throw ERR_STRING_TOO_LONG for UTF-8 (Michaël Zasso) #36661
  • [abc2ff47c2] - test: disable test-crypto-secure-heap with asan (James M Snell) #36900
  • [17a52337c4] - test: http complete response after socket double end (Dimitris Halatsis) #36633
  • [cc37ff24dc] - test: use faster variant for rss in test-crypto-dh-leak (Pooja D P) #36766
  • [daad0ab1cc] - test: use faster variant for rss in test-vm-memleak.js (Pooja D P) #36769
  • [9d25d25cfd] - test: mark test-cluster-bind-privileged-port flaky on arm (James M Snell) #36850
  • [c64db20fdd] - test: use faster variant for rss test-memoryusage-emfile (Pooja D P) #36768
  • [d48e00e5a3] - test: fix test-memory-usage.js for IBMi (Rich Trott) #36758
  • [9b7d2c2523] - test: guard large string decoder allocation (Michaël Zasso) #36795
  • [5bc130bd9e] - test: increase coverage for events (ZiJian Liu) #36668
  • [9f7fbcc64d] - test: add coverage for breakLength one-column array (Rich Trott) #36657
  • [9eff709c23] - test: update wpt interfaces (Daijiro Wachi) #36659
  • [a7f743f5cc] - test: update wpt resources (Daijiro Wachi) #36659
  • [4acc2732f9] - test: update wpt encoding (Daijiro Wachi) #36659
  • [986d5aca44] - test: update wpt url (Daijiro Wachi) #36659
  • [833e614682] - test: increase coverage for diagnostics_channel (ZiJian Liu) #36602
  • [f0dfe57bd1] - test: add already-aborted-controller test for spawn() (Rich Trott) #36644
  • [d5d56ec3d4] - test: add test for reused AbortController with execfile() (Rich Trott) #36644
  • [f81556563a] - test: increase coverage for internal/error_serdes.js (ZiJian Liu) #36628
  • [34d1d791e5] - test: improve coverage for util.inspect() with classes (Rich Trott) #36625
  • [1f3bc5ed73] - test: increase runInAsyncScope() coverage (Rich Trott) #36624
  • [863bfc44d2] - test: redirect stderr EnvironmentWithNoESMLoader (Daniel Bevenius) #36548
  • [8e8b16ff7e] - timers: refactor to use optional chaining (ZiJian Liu) #36767
  • [c23cca2de9] - tls: refactor to avoid unsafe array iteration (Antoine du Hamel) #36772
  • [37becfda8c] - tools: update all lint-md rollup dependencies (Michaël Zasso) #36843
  • [cfdbb79ccf] - tools: update doc tool dependencies (Michaël Zasso) #36844
  • [1f2a198c32] - tools: fix md5 hash for ICU 68.1 src (Richard Lau) #36777
  • [4e0995bc60] - tools: update ESLint to 7.17.0 (Colin Ihrig) #36726
  • [8ad3455ae3] - tools: revise install.py for minor improvements (Rich Trott) #36626
  • [b367d5a61d] - tools: update gyp-next to v0.7.0 (Michaël Zasso) #36580
  • [10f1c893c8] - tools: correct usage message for genv8constants.py (Rich Trott) #36606
  • [37b39a2d6b] - tools: call close() explicitly in genv8constants.py (Rich Trott) #36606
  • [7664f3678c] - tools: use is None consistently in Python (Rich Trott) #36606
  • [cb7f73c9d4] - tools: revise line in configure.py for clarity (Rich Trott) #36551
  • [258aa50986] - tty: refactor to avoid unsafe array iteration (Antoine du Hamel) #36771
  • [5cb8b16452] - url: fix url.format with ipv6 hostname (ZiJian Liu) #36665
  • [b1c6a44caf] - url: refactor to use more primordials (Antoine du Hamel) #36316
  • [baa8064bd0] - util: refactor inspect.js to use more primodials (Rohan Chougule) #36730
  • [bff201a66d] - util: remove unreachable defensive coding (Rich Trott) #36744
  • [64bf2f229e] - util: refactor to use more primordials (Antoine du Hamel) #36265
  • [2dd2ec3836] - v8: refactor to use more primordials (Antoine du Hamel) #36527
  • [3170636a8e] - (SEMVER-MINOR) v8: fix native serdes constructors (ExE Boss) #36549
  • [d5a9799e76] - wasi: refactor to avoid unsafe array iteration (Antoine du Hamel) #36724
  • [b6f74b0b09] - zlib: refactor to use primordial instead of <string>.startsWith (Rohan Chougule) #36718

dnlup and others added 30 commits January 5, 2021 11:22
This reverts commits:

* 55e83cb
* 6120028
* 70eaf55
* 5ae9690
* f20a88f
* a6bf74e
* 8154e47

Because of the breaking change in the order of emitting the `close`
event in `IncomingMessage` described in:
  #33035 (comment)

PR-URL: #36647
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36194
Backport-PR-URL: #36803
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Eliminate all overhead for function calls that are to be
hidden from the stack traces at the expense of
reduced performance for the error case

Fixes: #35386

PR-URL: #35644
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fixes: #13326
Refs: #13541
PR-URL: #36549
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* Replace unused identifier with Python convention `_`.
* Remove unneeded parentheses.
* Remove line-wrapping.

I confirmed that this doesn't change the output by running `./configure
--shared-zlib` and confirming that it created the same `common.gypi`
with and without these changes. The code changed here doesn't run unless
there is a `--shared-*` flag.

PR-URL: #36551
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36455
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
I was working on AbortSignal for spawn and noticed there is a leak in
the current code for AbortSignal support in child_process since it
removes the wrong listener. I used the new signal as argument feature
to make removing the listener easier and added a test.

PR-URL: #36424
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36527
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: #36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
We don't require an issue for a pull request, so this section usually
ends up displaying confusing default content.

PR-URL: #36590
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
The pull-request template was replicated in the pull-requests.md which
is a maintenance annoyance when changing the template. Replace the
replication with a link to the raw template.

PR-URL: #36590
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Fixes: #36598

PR-URL: #36599
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit adds a suggestion to redirect stderr for
EnvironmentTest.EnvironmentWithNoESMLoader.

The motivation for this is that currently this tests prints the
following error (which is expected):

vm:module(0):1
globalThis.importResult = import("")
^

Error: Not supported
 at vm:module(0):1:1
 at SourceTextModule.evaluate (node:internal/vm/module:229:23)
 at node:embedder_main_12:1:328
 at processTicksAndRejections (node:internal/process/task_queues:93:5)

It might not be obvious which test caused this error just by looking at
the output above and it would be nice if it was not displayed.

PR-URL: #36548
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Original commit message:

    [coverage] fix greedy nullish coalescing

    The SourceRangeScope helper was consuming too many characters, instead
    explicitly create SourceRange, based on scanner position.

    Bug: v8:11231
    Change-Id: I852d211227abacf867e8f1ab3e3ab06dbdba2a9b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576006
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71765}

Refs: v8/v8@dfcdf78

PR-URL: #36573
Fixes: #36619
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #36603
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
We use `is None` instead of `== None` everywhere (which mostly just
means test.py) except in one place in genv8constants.py. Switch to `is
None` in genv8constants.py. This is slightly more efficient, although I
can't imagine that makes a measurable difference here.

PR-URL: #36606
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #36606
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #36606
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #36509
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Refs: #35281
Refs: #36550

Co-authored-by: raisinten <raisinten@gmail.com>

PR-URL: #36601
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36304
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36428
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36526
Reviewed-By: Rich Trott <rtrott@gmail.com>
Using an explicit constructor is necessary to avoid relying on
`Array.prototype[Symbol.iterator]` and `%ArrayIteratorPrototype%.next`,
which can be mutated by users.

PR-URL: #36587
Refs: #36428
Refs: #36532
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Adds a simple benchmark for https server based on the http simple
benchmark. Updates benchmarker integration for autocannon and wrk,
so that they support https scheme.

Also adds a new HTTPS section and improves HTTP/2 section in
the benchmark guide.

PR-URL: #36612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36316
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36560
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0

PR-URL: #36580
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Add missing topic about what https.request() returns.

PR-URL: #36370
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
PR-URL: #36480
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #36630
Backport-PR-URL: #36890
Refs: #32329
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams added a commit that referenced this pull request Jan 13, 2021
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
  * implement basic secure heap support (James M Snell) [#36779](#36779)
  * fixup bug in keygen error handling (James M Snell) [#36779](#36779)
  * introduce X509Certificate API (James M Snell) [#36804](#36804)
  * implement randomuuid (James M Snell) [#36729](#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
  * add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
  * add panva to collaborators (Filip Skokan) [#36802](#36802)
  * add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
  * fix native  constructors (ExE Boss) [#36549](#36549)
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Copy link
Member

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message for cf44a24 reads 2020 rather than 2021 (it does still feel like it). Shouldn't be necessary to rerun all of the CIs if that's the only update though

@danielleadams
Copy link
Contributor Author

danielleadams commented Jan 13, 2021

@BethGriggs 🤦🏼‍♀️ thanks, fixed.

danielleadams added a commit that referenced this pull request Jan 13, 2021
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
  * implement basic secure heap support (James M Snell) [#36779](#36779)
  * fixup bug in keygen error handling (James M Snell) [#36779](#36779)
  * introduce X509Certificate API (James M Snell) [#36804](#36804)
  * implement randomuuid (James M Snell) [#36729](#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
  * add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
  * add panva to collaborators (Filip Skokan) [#36802](#36802)
  * add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
  * fix native  constructors (ExE Boss) [#36549](#36549)
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs nodejs deleted a comment from nodejs-github-bot Jan 14, 2021
danielleadams added a commit that referenced this pull request Jan 14, 2021
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) [#29412](#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) [#36603](#36603)
* crypto:
  * implement basic secure heap support (James M Snell) [#36779](#36779)
  * fixup bug in keygen error handling (James M Snell) [#36779](#36779)
  * introduce X509Certificate API (James M Snell) [#36804](#36804)
  * implement randomuuid (James M Snell) [#36729](#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) [#36793](#36793)
  * add dnlup to collaborators (Daniele Belardi) [#36849](#36849)
  * add panva to collaborators (Filip Skokan) [#36802](#36802)
  * add yashLadha to collaborator (Yash Ladha) [#36666](#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) [#36685](#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) [#36623](#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) [#34291](#34291)
* v8:
  * fix native  constructors (ExE Boss) [#36549](#36549)
@danielleadams
Copy link
Contributor Author

Tests are passing 🎉 so this is ready to go. (@nodejs/releasers)

I am running a citgm smoker on branch v15.x to check for new errors from packages, but it looks like a lot of the errors are from packages that have not passed on previous 15.x releases.

PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) (#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) (#36603)
* crypto:
  * implement basic secure heap support (James M Snell) (#36779)
  * fixup bug in keygen error handling (James M Snell) (#36779)
  * introduce X509Certificate API (James M Snell) (#36804)
  * implement randomuuid (James M Snell) (#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) (#36793)
  * add dnlup to collaborators (Daniele Belardi) (#36849)
  * add panva to collaborators (Filip Skokan) (#36802)
  * add yashLadha to collaborator (Yash Ladha) (#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) (#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) (#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) (#34291)
* v8:
  * fix native  constructors (ExE Boss) (#36549)
@danielleadams danielleadams merged commit 1700bbd into v15.x Jan 15, 2021
danielleadams added a commit that referenced this pull request Jan 15, 2021
danielleadams added a commit that referenced this pull request Jan 15, 2021
PR-URL: #36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) (#29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) (#36603)
* crypto:
  * implement basic secure heap support (James M Snell) (#36779)
  * fixup bug in keygen error handling (James M Snell) (#36779)
  * introduce X509Certificate API (James M Snell) (#36804)
  * implement randomuuid (James M Snell) (#36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) (#36793)
  * add dnlup to collaborators (Daniele Belardi) (#36849)
  * add panva to collaborators (Filip Skokan) (#36802)
  * add yashLadha to collaborator (Yash Ladha) (#36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) (#36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) (#36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) (#34291)
* v8:
  * fix native  constructors (ExE Boss) (#36549)
@danielleadams danielleadams deleted the v15.6.0-proposal branch January 15, 2021 01:03
danielleadams pushed a commit to danielleadams/nodejs.org that referenced this pull request Jan 15, 2021
danielleadams added a commit to nodejs/nodejs.org that referenced this pull request Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.