tty: refactor to avoid unsafe array iteration #36771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
reviewed
Jan 4, 2021
lib/tty.js
Outdated
| @@ -132,7 +132,7 @@ WriteStream.prototype._refreshSize = function() { | |||
| this.emit('error', errors.errnoException(err, 'getWindowSize')); | |||
| return; | |||
| } | |||
| const [newCols, newRows] = winSize; | |||
| const { 0: newCols, 1: newRows } = winSize; | |||
There was a problem hiding this comment.
Is this supposed to be more efficient?
There was a problem hiding this comment.
Not really (it's probably equivalent performance wise), it's to avoid calling user-mutable Array.prototype[Symbol.iterator] and %ArrayIteratorPrototype%.next.
Trott
approved these changes
Jan 5, 2021
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
PoojaDurgad
approved these changes
Jan 5, 2021
|
Landed in b12127a |
aduh95
force-pushed
the
tty-array-iteration
branch
from
f808e31 to
b12127a
Compare
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #36771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes