Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify subprocess.stdout/in/err/io properties #36784

Closed
wants to merge 1 commit into from
Closed

doc: clarify subprocess.stdout/in/err/io properties #36784

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 4, 2021

The various subprocess.stdwhatever properties can be null or
undefined in certain conditions.

Fixes: #33458
Signed-off-by: James M Snell jasnell@gmail.com

@jasnell
doc: clarify subprocess.stdout/in/err/io properties
8da0b14 
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.

Fixes: nodejs#33458
Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jan 4, 2021
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 6, 2021
@jasnell
Copy link
Member Author

jasnell commented Jan 6, 2021

This shouldn't need to wait the full time to land. Please 👍🏻 to fast-track

jasnell added a commit that referenced this pull request Jan 7, 2021
@jasnell
doc: clarify subprocess.stdout/in/err/io properties
8ce6583 
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.

Fixes: #33458
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36784
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Jan 7, 2021

Landed in 8ce6583

@jasnell jasnell closed this Jan 7, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell @danielleadams
doc: clarify subprocess.stdout/in/err/io properties
d4bcb36 
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.

Fixes: #33458
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36784
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: clarify subprocess.stdout/in/err/io properties
c1ea23c 
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.

Fixes: #33458
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36784
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: child_process.SpawnSync output, stdout, stderr can be null
3 participants
@jasnell @lpinca @nodejs-github-bot