tools: revise install.py for minor improvements #36626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
Trott
added
python
github-actions
bot
removed
the
request-ci
aduh95
reviewed
Dec 25, 2020
aduh95
approved these changes
Dec 25, 2020
cclauss
reviewed
Dec 25, 2020
tools/install.py
Outdated
| @@ -19,7 +19,8 @@ def abspath(*args): | |||
| return os.path.abspath(path) | |||
|
|
|||
| def load_config(): | |||
| s = open('config.gypi').read() | |||
| with open('config.gypi') as f: | |||
| s = f.read() | |||
There was a problem hiding this comment.
Suggested change
| s = f.read() | |
| return ast.literal_eval(f.read()) |
There was a problem hiding this comment.
Added in a fixup commit. Thanks for the review!
cclauss
approved these changes
Dec 26, 2020
* Use an with block for reading the config file. Refs: https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files * Use explicit blank return to make it clear that the return value is not actually used and that it is being used for flow control only.. PR-URL: nodejs#36626 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Trott
force-pushed
the
install-refactor
branch
from
46ee377 to
245159f
Compare
|
Landed in 245159f |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
* Use an with block for reading the config file. Refs: https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files * Use explicit blank return to make it clear that the return value is not actually used and that it is being used for flow control only.. PR-URL: #36626 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
* Use an with block for reading the config file. Refs: https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files * Use explicit blank return to make it clear that the return value is not actually used and that it is being used for flow control only.. PR-URL: #36626 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an with block for reading the config file.
Refs: https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files
Use explicit blank return to make it clear that the return value is
not actually used and that it is being used for flow control only..
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes