Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: guard large string decoder allocation #36795

Merged
merged 1 commit into from
Jan 5, 2021
Merged

test: guard large string decoder allocation #36795

merged 1 commit into from
Jan 5, 2021

Conversation

targos
Copy link
Member

@targos targos commented Jan 5, 2021

Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 5, 2021
@targos targos mentioned this pull request Jan 5, 2021
Closed
@targos targos added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021
@targos
Copy link
Member Author

targos commented Jan 5, 2021

👍 to fast-track and make ARM CI green.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35268/

@targos @aduh95
test: guard large string decoder allocation
e5b8c61 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: nodejs#36792

PR-URL: nodejs#36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Jan 5, 2021

Landed in e5b8c61

@aduh95 aduh95 merged commit e5b8c61 into nodejs:master Jan 5, 2021
@targos targos deleted the fix-36792 branch January 5, 2021 08:43
@mhdawson
Copy link
Member

mhdawson commented Jan 5, 2021

@targos thanks!

danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@targos @danielleadams
test: guard large string decoder allocation
9b7d2c2 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos added a commit that referenced this pull request May 25, 2021
@targos
test: guard large string decoder allocation
7f0d5d3 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit that referenced this pull request Jun 5, 2021
@targos
test: guard large string decoder allocation
c9135b8 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos added a commit that referenced this pull request Jun 11, 2021
@targos
test: guard large string decoder allocation
c34de75 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@StefanStojanovic StefanStojanovic mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@aduh95 aduh95 aduh95 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-string-decoder failing regularly on arm
6 participants
@targos @nodejs-github-bot @aduh95 @mhdawson @gireeshpunathil @PoojaDurgad