Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor to use validateAbortSignal #36604

Merged
merged 1 commit into from
Dec 27, 2020
Merged

lib: refactor to use validateAbortSignal #36604

merged 1 commit into from
Dec 27, 2020

Conversation

Lxxyx
Copy link
Member

@Lxxyx Lxxyx commented Dec 22, 2020 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Dec 22, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35045/

lpinca
lpinca reviewed Dec 22, 2020
View reviewed changes
lib/internal/quic/core.js Outdated Show resolved Hide resolved
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35049/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35050/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 26, 2020
@Lxxyx @Trott
quic,timers: refactor to use validateAbortSignal
4905501 
PR-URL: nodejs#36604
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@Trott Trott force-pushed the refactor-to-use-validate-abort-signal branch from e402095 to 4905501 Compare December 27, 2020 14:38
@Trott Trott merged commit 4905501 into nodejs:master Dec 27, 2020
@Trott
Copy link
Member

Trott commented Dec 27, 2020

Landed in 4905501

@Lxxyx Lxxyx deleted the refactor-to-use-validate-abort-signal branch December 27, 2020 15:01
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Lxxyx @danielleadams
quic,timers: refactor to use validateAbortSignal
8b7336b 
PR-URL: #36604
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
@Lxxyx @targos
timers: refactor to use validateAbortSignal
e7f996d 
PR-URL: nodejs#36604
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Apr 24, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
@Lxxyx @targos
timers: refactor to use validateAbortSignal
3ac1139 
PR-URL: nodejs#36604
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@Lxxyx @targos
timers: refactor to use validateAbortSignal
130b797 
PR-URL: nodejs#36604
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Apr 30, 2021
@Lxxyx @targos
timers: refactor to use validateAbortSignal
1b74a08 
PR-URL: #36604
Backport-PR-URL: #38386
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Apr 30, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca left review comments

@juanarbol juanarbol juanarbol approved these changes

@richardlau richardlau richardlau approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Lxxyx @nodejs-github-bot @Trott @benjamingr @lpinca @richardlau @juanarbol @targos @aduh95