-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: revise method text in async_hooks.md #36736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
Issues and PRs related to the async hooks subsystem.
doc
Issues and PRs related to the documentations.
labels
Jan 2, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
reviewed
Jan 2, 2021
RaisinTen
reviewed
Jan 2, 2021
@nodejs/documentation |
gireeshpunathil
approved these changes
Jan 5, 2021
aymen94
approved these changes
Jan 7, 2021
HarshithaKP
approved these changes
Jan 7, 2021
Fix two typographical errors ("This methods") and general minor edits around the use of the word "method" in async_hooks.md. PR-URL: nodejs#36736 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Landed in 67c8e2b |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Fix two typographical errors ("This methods") and general minor edits around the use of the word "method" in async_hooks.md. PR-URL: #36736 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Fix two typographical errors ("This methods") and general minor edits around the use of the word "method" in async_hooks.md. PR-URL: #36736 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
async_hooks
Issues and PRs related to the async hooks subsystem.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two typographical errors ("This methods") and general minor edits
around the use of the word "method" in async_hooks.md.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes