Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: expand openssl instructions #36554

Closed
wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

Related Issues

Fixes: https://github.com/nodejs/node/issues/<issue_number>

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Refs: nodejs#36541

Expand the instructions to cover what is needed when
updates are required across all active release lines
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 17, 2020
@mhdawson mhdawson mentioned this pull request Dec 17, 2020
2 tasks
@@ -2,6 +2,18 @@

This document describes how to update `deps/openssl/`.

If you need to provide updates across all active release lines you will
currently need to generate two PRs as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time round we did three PRs -- one for current (including the QUIC patches), one for 14.x (without the the QUIC patches) and one for 10.x.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k will update for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau updated

@mhdawson
Copy link
Member Author

@MylesBorins could you review/approve so I can land?

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The only concern I have with documenting this is that 10.x is going EOL in april and we won't want to keep the stale docs... so we just need to remember to remove this

@mhdawson
Copy link
Member Author

@MylesBorins understood on updating the docs. I can try to remember to do that, but I think the value of having the info is worth it.

@mhdawson
Copy link
Member Author

Do only change and linters have passed, landing.

mhdawson added a commit that referenced this pull request Dec 22, 2020
Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: #36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@mhdawson
Copy link
Member Author

Landed in e22b751

@mhdawson mhdawson closed this Dec 22, 2020
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: #36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 16, 2021
Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: #36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: #36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants