Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify pull request template #36739

Closed
wants to merge 0 commits into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 2, 2021

Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.

Checklist

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 2, 2021
@yashLadha yashLadha added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 3, 2021
Trott added a commit to Trott/io.js that referenced this pull request Jan 4, 2021
Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.

PR-URL: nodejs#36739
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
@Trott Trott closed this Jan 4, 2021
@Trott
Copy link
Member Author

Trott commented Jan 4, 2021

Landed in 551251e

@Trott Trott deleted the pr-template branch January 4, 2021 16:26
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.

PR-URL: #36739
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.

PR-URL: #36739
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants