Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patches npm 6.14.11 #37173

Closed
wants to merge 1 commit into from
Closed

deps: patches npm 6.14.11 #37173

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

Patches the update to npm@6.14.11 that was missing some of the file updates.

Original changelog:

6.14.11 (2021-01-07)

DEPENDENCIES

DOCUMENTATION

TESTING

cc @BethGriggs

@nodejs-github-bot nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. v14.x labels Feb 1, 2021
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35875/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2021 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/35881/ ✅

@BethGriggs
Copy link
Member

CI ✅ .

I noticed that #37107 had 160 files changed, this PR has 159 files changed, and #36838 had 157.

I would appreciate a review/approval from @nodejs/npm (just to confirm)

@ruyadorno
Copy link
Member Author

ruyadorno commented Feb 2, 2021 •
edited
Loading

@BethGriggs 👍 it does LGTM

The missing file between this PR and #37107 seems to be deps/npm/node_modules/json-schema/draft-03/examples/calendar which is but an example file within the transitive dependency, that said I'm not sure why it was included at first and not now. 🤔

#36838 was missing a couple of files (which is the reason why we need to patch this now) so that's expected 😄

@BethGriggs
Copy link
Member

Thank you @ruyadorno

I think it'd still be preferable for an explicit review/approval from @nodejs/npm before landing

@BethGriggs BethGriggs added the review wanted PRs that need reviews. label Feb 3, 2021
MylesBorins
MylesBorins approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethGriggs BethGriggs removed the review wanted PRs that need reviews. label Feb 3, 2021
BethGriggs pushed a commit that referenced this pull request Feb 4, 2021
@ruyadorno @BethGriggs
deps: upgrade npm to 6.14.11
408c7a6 
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@BethGriggs
Copy link
Member

Landed in 408c7a6 (v14.x-staging)

@BethGriggs BethGriggs closed this Feb 4, 2021
richardlau pushed a commit that referenced this pull request Feb 5, 2021
@ruyadorno @richardlau
deps: upgrade npm to 6.14.11
d6f3694 
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
BethGriggs added a commit that referenced this pull request Feb 5, 2021
@BethGriggs
2021-02-08, Version 14.15.5 'Fermium' (LTS)
a1b41b3 
Notable changes:

- **deps**: upgrade npm to 6.14.11 (Ruy Adorno)
  (#37173)
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
@BethGriggs BethGriggs mentioned this pull request Feb 5, 2021
Merged
@richardlau richardlau mentioned this pull request Feb 5, 2021
Merged
BethGriggs added a commit that referenced this pull request Feb 8, 2021
@BethGriggs
2021-02-08, Version 14.15.5 'Fermium' (LTS)
7b6ab5e 
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Feb 8, 2021
@ruyadorno @richardlau
deps: upgrade npm to 6.14.11
54617f3 
PR-URL: nodejs#37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@richardlau richardlau mentioned this pull request Feb 8, 2021
Closed
BethGriggs added a commit that referenced this pull request Feb 8, 2021
@BethGriggs
2021-02-09, Version 14.15.5 'Fermium' (LTS)
9fff0d3 
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
ruyadorno added a commit that referenced this pull request Feb 8, 2021
@ruyadorno
deps: upgrade npm to 6.14.11
427968d 
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
ruyadorno added a commit that referenced this pull request Feb 9, 2021
@ruyadorno
2021-02-09, Version 12.20.2 (LTS)
e28966f 
Notable changes:

* deps:
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
ruyadorno added a commit that referenced this pull request Feb 9, 2021
@ruyadorno
2021-02-09, Version 12.20.2 'Erbium' (LTS)
209e1ba 
Notable changes:

* deps:
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
ruyadorno added a commit that referenced this pull request Feb 9, 2021
@ruyadorno
2021-02-09, Version 12.20.2 'Erbium' (LTS)
34eefac 
Notable changes:

* deps:
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
    * Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
@ruyadorno ruyadorno mentioned this pull request Feb 9, 2021
Merged
ruyadorno added a commit that referenced this pull request Feb 9, 2021
@ruyadorno
2021-02-09, Version 12.20.2 'Erbium' (LTS)
6310a81 
Notable changes:

* deps:
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
    * Note: Node.js is not believed to be vulnerable to CVE-2021-21148.

PR-URL: #37286
richardlau pushed a commit that referenced this pull request Feb 9, 2021
@ruyadorno @richardlau
deps: upgrade npm to 6.14.11
fe2c980 
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Backport-PR-URL: #37278

Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
BethGriggs added a commit that referenced this pull request Feb 9, 2021
@BethGriggs
2021-02-09, Version 14.15.5 'Fermium' (LTS)
4f12215 
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
ruyadorno added a commit that referenced this pull request Feb 10, 2021
@ruyadorno
2021-02-10, Version 12.20.2 'Erbium' (LTS)
abf8088 
Notable changes:

* deps:
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)

PR-URL: #37286
ruyadorno added a commit that referenced this pull request Feb 10, 2021
@ruyadorno
2021-02-10, Version 12.20.2 'Erbium' (LTS)
ad38be4 
Notable changes:

* deps:
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)

PR-URL: #37286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruyadorno @nodejs-github-bot @BethGriggs @MylesBorins