Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: backport dfcf1e86fac0 #37245

Closed
wants to merge 1 commit into from
Closed

deps: V8: backport dfcf1e86fac0 #37245

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Feb 6, 2021

Original commit message:

[wasm] PostMessage of Memory.buffer should throw

PostMessage of an ArrayBuffer that is not detachable should result
in a DataCloneError.

Bug: chromium:1170176, chromium:961059
Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72415}

Refs: v8/v8@dfcf1e8

@targos
deps: V8: backport dfcf1e86fac0
d92428a 
Original commit message:

    [wasm] PostMessage of Memory.buffer should throw

    PostMessage of an ArrayBuffer that is not detachable should result
    in a DataCloneError.

    Bug: chromium:1170176, chromium:961059
    Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72415}

Refs: v8/v8@dfcf1e8
@targos targos added v8 engine Issues and PRs related to the V8 dependency. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 6, 2021
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 6, 2021
@targos
Copy link
Member Author

targos commented Feb 6, 2021

Fast-track to include in #37074.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 6, 2021 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/35973/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3733/
Rebuild: https://ci.nodejs.org/job/node-test-commit-v8-linux/3735/ ✅

aduh95
aduh95 approved these changes Feb 6, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

mcollina
mcollina approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and +1 to fast-track

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35980/

@Trott
Copy link
Member

Trott commented Feb 6, 2021

Is the heap test failure in the initial V8 CI anything to worry about?

@targos
Copy link
Member Author

targos commented Feb 7, 2021

Is the heap test failure in the initial V8 CI anything to worry about?

It's certainly not related to this change. I say we worry about it only if it happens again, maybe the machine was high on memory.

@targos
Copy link
Member Author

targos commented Feb 7, 2021

Landed in aac2713

@targos targos closed this Feb 7, 2021
@targos targos deleted the v8-fix branch February 7, 2021 09:25
targos added a commit that referenced this pull request Feb 7, 2021
@targos
deps: V8: backport dfcf1e86fac0
aac2713 
Original commit message:

    [wasm] PostMessage of Memory.buffer should throw

    PostMessage of an ArrayBuffer that is not detachable should result
    in a DataCloneError.

    Bug: chromium:1170176, chromium:961059
    Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72415}

Refs: v8/v8@dfcf1e8

PR-URL: #37245
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 8, 2021
@targos @BethGriggs
deps: V8: backport dfcf1e86fac0
20b1e6c 
Original commit message:

    [wasm] PostMessage of Memory.buffer should throw

    PostMessage of an ArrayBuffer that is not detachable should result
    in a DataCloneError.

    Bug: chromium:1170176, chromium:961059
    Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72415}

Refs: v8/v8@dfcf1e8

PR-URL: #37245
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 8, 2021
@BethGriggs
2021-02-08, Version 14.15.5 'Fermium' (LTS)
7b6ab5e 
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
BethGriggs added a commit that referenced this pull request Feb 8, 2021
@BethGriggs
2021-02-09, Version 14.15.5 'Fermium' (LTS)
9fff0d3 
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
@BethGriggs BethGriggs mentioned this pull request Feb 8, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Feb 8, 2021
@targos @ruyadorno
deps: V8: backport dfcf1e86fac0
680496e 
Original commit message:

    [wasm] PostMessage of Memory.buffer should throw

    PostMessage of an ArrayBuffer that is not detachable should result
    in a DataCloneError.

    Bug: chromium:1170176, chromium:961059
    Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72415}

Refs: v8/v8@dfcf1e8

PR-URL: #37245
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ruyadorno added a commit that referenced this pull request Feb 9, 2021
@ruyadorno
2021-02-09, Version 12.20.2 (LTS)
e28966f 
Notable changes:

* deps:
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
ruyadorno added a commit that referenced this pull request Feb 9, 2021
@ruyadorno
2021-02-09, Version 12.20.2 'Erbium' (LTS)
209e1ba 
Notable changes:

* deps:
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
ruyadorno added a commit that referenced this pull request Feb 9, 2021
@ruyadorno
2021-02-09, Version 12.20.2 'Erbium' (LTS)
34eefac 
Notable changes:

* deps:
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
    * Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
@ruyadorno ruyadorno mentioned this pull request Feb 9, 2021
Merged
ruyadorno added a commit that referenced this pull request Feb 9, 2021
@ruyadorno
2021-02-09, Version 12.20.2 'Erbium' (LTS)
6310a81 
Notable changes:

* deps:
  * upgrade npm to 6.14.11 (Ruy Adorno) [#37173](#37173)
  * V8: backport dfcf1e86fac0 (Michaël Zasso) [#37245](#37245)
    * Note: Node.js is not believed to be vulnerable to CVE-2021-21148.

PR-URL: #37286
BethGriggs added a commit that referenced this pull request Feb 9, 2021
@BethGriggs
2021-02-09, Version 14.15.5 'Fermium' (LTS)
4f12215 
Notable changes:

- **deps**:
  - upgrade npm to 6.14.11 (Ruy Adorno)
    (#37173)
  - V8: backport dfcf1e86fac0 (Michaël Zasso)
    (#37245)
    - Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
  (#36618)

PR-URL: #37074
@ruyadorno
Copy link
Member

ruyadorno commented Feb 10, 2021 •
edited
Loading

This did not landed cleanly in v12.x and I believe it might need to be properly backported.

I tried to land it directly and manually fixed conflicts (result being 680496e) but that ended up breaking all V8 ci tests. I believe a more informed backport is required here 😊

@targos
Copy link
Member Author

targos commented Feb 12, 2021

If this patch doesn't work for v12.x, I don't know who has the knowledge and time to work on a correct one :(

danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@targos @danielleadams
deps: V8: backport dfcf1e86fac0
20c65b0 
Original commit message:

    [wasm] PostMessage of Memory.buffer should throw

    PostMessage of an ArrayBuffer that is not detachable should result
    in a DataCloneError.

    Bug: chromium:1170176, chromium:961059
    Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72415}

Refs: v8/v8@dfcf1e8

PR-URL: #37245
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@vdeturckheim vdeturckheim vdeturckheim approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@danbev danbev danbev approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @Trott @ruyadorno @mcollina @danbev @cjihrig @vdeturckheim @aduh95