test: fix flaky test-webcrypto-encrypt-decrypt-aes #37373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
changed the title
Use Object.assign() to make shallow copies of the object passed to the test functions. The test functions are passed to Promise.all() so execution order is not guaranteed. So using the same object in all of them is a race condition where one test can have side effects in another. Fixes: nodejs#35586
|
Are these objects modified by the test or by core APIs? |
@targos Yes, the contents of |
|
Oh, but if we're modifying the contents of the |
🤦♂️ I'll run a stress test to confirm, and then make a shallow copy of the property to confirm that fixes it. |
|
I think something is wrong inside the function too and I think this will be a fix: #37380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Object.assign() to make shallow copies of the object passed to the
test functions. The test functions are passed to Promise.all() so
execution order is not guaranteed. So using the same object in all of
them is a race condition where one test can have side effects in
another.
Fixes: #35586